Skip to content

Conversation

@Lokowitz
Copy link
Contributor

@Lokowitz Lokowitz commented Sep 28, 2025

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

In server/lib/validators.ts z.cidr() and z.ip() musst be changed to z.cidrv4() and z.ipv4().
Is there need for ipv6 validation?
-> added v6 support

Removed the "^" in package.json versions to avoid changes in packages-lock.json by accident when installing packages on a PR.

Migration guide
Codemod

Fixes #1514
Fixes #1513
Fixes #1277

@oschwartz10612
Copy link
Member

Hey @Lokowitz sorry for all of the changes yanked up from saas which probably require a rebase... and for my delay. LMK if you need me to rebase. As usually thanks for doing this kind of work its incredibly helpful!

Is there need for ipv6 validation?

I think we probably should validate an IP input is either v4 or v6 as we slowly more formally support v6. Most places (like the target hostnames) we dont care because it can be DNS as well - but if it is a actually IP then we probably should?

LKM if you need help on this one and feel free to ping me or mark it as ready when you are good to go!

@Lokowitz Lokowitz changed the base branch from main to dev October 6, 2025 20:43
@Lokowitz
Copy link
Contributor Author

Lokowitz commented Oct 7, 2025

@oschwartz10612 Very happy to support you!
And thanks for the appreciation.
I made a rebase with dev branch and changed the PR against dev.
Added support for v6 in validation.
Saw a lot of hints in CodeQL checkof GitHub, maybe you want to check 🙂

It's a heavy change so no stress on checking/merging. I think this will break all the current PRs.

You are welcome to have already a look on it, but I did no testing in Prod system. That's the reason it is still in draft.

@Lokowitz Lokowitz changed the title Fix upgrade zod from 3.25.76 to 4.1.11 Fix upgrade zod from 3.25.76 to 4.1.12 Oct 20, 2025
@Lokowitz Lokowitz marked this pull request as ready for review October 20, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants