Skip to content

Conversation

zlav
Copy link
Member

@zlav zlav commented Aug 7, 2025

Overview

Closes #1571

godebug, toolchain, and tool all support multi-line formatted config options. We only support. I outlined this in a previous PR that added initial support but had to move on to other things.

module main

go 1.24.0

tool (
	github.com/bufbuild/buf/cmd/buf
	github.com/wadey/gocovmerge
)

Acceptance criteria

  • godebug, toolchain, and tool all support multi line config options.

Testing plan

  1. Add correct tests and ensure they pass
  2. Build the CLI locally and run it on an example go.mod file that has these multi line comments.

I modified an existing go project (terraform) but you could do any repo or scan the test file if you'd like.

Risks

I can't think of any for this PR

References

Add links to any referenced GitHub issues, Zendesk tickets, Jira tickets, Slack threads, etc.

Example:

ANE-2600: Implement multi line toolchain support

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@zlav zlav requested a review from a team as a code owner August 7, 2025 22:52
@zlav zlav requested a review from james-fossa August 7, 2025 22:52
@zlav zlav requested review from csasarak and removed request for james-fossa August 7, 2025 22:59
@zlav zlav force-pushed the fix/multi-line-tool-go-directives branch from 11f9d72 to b5cebb9 Compare September 10, 2025 00:51
@zlav zlav changed the title Support multi line godebug and tool directive statements. [ANE-2600] Support multi line godebug and tool directive statements. Sep 12, 2025
Copy link
Contributor

@csasarak csasarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'd just go through the comments and make sure they are addressing why/how rather than just describing what code is doing.

@zlav zlav enabled auto-merge (squash) September 12, 2025 17:24
@zlav zlav merged commit 8958d33 into master Sep 12, 2025
21 of 25 checks passed
@zlav zlav deleted the fix/multi-line-tool-go-directives branch September 12, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Can't fully work with go tool directive

2 participants