Rough cut no ficus buffering. #1591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spatten
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
I think this is a good change and we can and should ship it.
I added one question about logging something if we encounter multiple messages from Ficus that give us a snippet scan analysis ID.
Other than that, we should:
- clean up the comments (and I know you just pushed this up and left them in knowing they needed to be cleaned up)
- add an entry to the Changelog
and then ship this
src/App/Fossa/Ficus/Analyze.hs
Outdated
| <> " debug messages, " | ||
| <> pretty (length $ ficusMessageFindings messages) | ||
| <> " findings" | ||
| -- logDebug $ |
There was a problem hiding this comment.
Let's get rid of these comments
|
I tested this by compiling it and running against a directory with many copies of Linux. On master, Ficus completed in around 20 minutes, but then the CLI just hung for > 1 hour. I gave up on it ever completing so don't know how long it actually took On this branch, Ficus completed in around 20 minutes and the CLI got the analysis ID properly and everything worked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Provide an overview of this change. Describe the intent of this change, and how it implements that intent.
Example: This PR accomplishes X by doing Y.
Acceptance criteria
If this PR is successful, what impact does it have on the user experience?
Example: When users do X, Y should now happen.
Testing plan
How did you validate that this PR works? What literal steps did you take when manually checking that your code works?
Example:
This section should list concrete steps that a reviewer can sanity check and repeat on their own machine (and provide any needed test cases).
Risks
Highlight any areas that you're unsure of, want feedback on, or want reviewers to pay particular attention to.
Example: I'm not sure I did X correctly, can reviewers please double-check that for me?
Metrics
Is this change something that can or should be tracked? If so, can we do it today? And how? If its easy, do it
References
Add links to any referenced GitHub issues, Zendesk tickets, Jira tickets, Slack threads, etc.
Example:
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an## Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.