Skip to content

Patch: Changes to deploy the extension on chrome webstore #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025

Conversation

vedansh-5
Copy link
Contributor

@vedansh-5 vedansh-5 commented Jul 18, 2025

📝 Summary of Changes

In this PR I intend to remove the violating code for publishing the extension.


📸 Screenshots / Demo (if UI-related)

Add screenshots, video, or link to deployed preview if applicable


✅ Checklist

  • I’ve tested my changes locally
  • I’ve added tests (if applicable)
  • I’ve updated documentation (if applicable)
  • My code follows the project’s code style guidelines

👀 Reviewer Notes

Add any special notes for the reviewer here

Summary by Sourcery

Remove disallowed tab-refresh code and restrict extension permissions to prepare for Chrome Webstore deployment

Enhancements:

  • Eliminate chrome.tabs messaging and automatic tab reload logic from refresh handler
  • Remove tabs, activeTab, and notifications permissions from manifest.json
  • Limit manifest permissions to storage only

Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
Copy link
Contributor

sourcery-ai bot commented Jul 18, 2025

Reviewer's Guide

This PR removes direct tab interactions in the UI script and restricts manifest permissions to comply with Chrome Web Store policies.

Entity relationship diagram for updated manifest permissions

erDiagram
    EXTENSION ||--o{ PERMISSION : includes
    PERMISSION {
        string name
    }
    EXTENSION {
        string id
        string name
    }
    %% Only 'storage' permission remains; 'tabs', 'activeTab', and 'notifications' are removed.
Loading

Class diagram for main.js after removing tab interactions

classDiagram
    class MainScript {
        +refreshCacheButton
        +refreshCacheClickHandler()
    }
    %% Previously, MainScript used chrome.tabs and chrome.tabs.sendMessage, which are now removed.
    %% Now, only Materialize.toast and error logging remain in the handler.
Loading

File-Level Changes

Change Details Files
Removed direct interaction with chrome.tabs API in refreshCache handler
  • Deleted chrome.tabs.query call
  • Removed chrome.tabs.sendMessage action
  • Removed chrome.tabs.reload invocation
src/scripts/main.js
Reduced extension permissions in manifest to comply with policy
  • Removed tabs, activeTab, and notifications permissions
  • Retained only storage permission
src/manifest.json

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vedansh-5 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
@vedansh-5
Copy link
Contributor Author

I have made changes in this PR that are required to get our extension pass the review of chrome web store. Please take a look whenever you can @hpdang @Preeti9764 .
The extension was using extra permissions that were not being used and it was fetching remote code that was being used in css and icons, both of these are violations to the chrome policy. I have now removed the extra permissions and removed the reference to external code and added those files locally in our extension.
Thankyou.

@hpdang
Copy link
Member

hpdang commented Jul 21, 2025

LGTM @Preeti9764 could you please also check this?

@Preeti9764
Copy link
Contributor

Preeti9764 commented Jul 21, 2025

@vedansh-5 ,please fix this [obejct Object] in ui,when i click the refresh button , you mentioned this in pr#128 can you please check is it for this only or gitlab pr also cause i dont find it there.Thanks!
image

Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
@vedansh-5
Copy link
Contributor Author

@Preeti9764 I have fixed the above, could you check it again, I'll make a review again on the #128 for the same.

@vedansh-5 vedansh-5 self-assigned this Jul 21, 2025
@Preeti9764
Copy link
Contributor

@hpdang @vedansh-5 I have checked the bug is no more.Thanks!

@hpdang hpdang merged commit 0b76d82 into fossasia:master Jul 21, 2025
@vedansh-5 vedansh-5 deleted the chromeDeploy branch August 1, 2025 13:22
@vedansh-5 vedansh-5 changed the title Changes to deploy the extension on chrome webstore Patch: Changes to deploy the extension on chrome webstore Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants