-
Notifications
You must be signed in to change notification settings - Fork 90
Patch: Changes to deploy the extension on chrome webstore #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
Reviewer's GuideThis PR removes direct tab interactions in the UI script and restricts manifest permissions to comply with Chrome Web Store policies. Entity relationship diagram for updated manifest permissionserDiagram
EXTENSION ||--o{ PERMISSION : includes
PERMISSION {
string name
}
EXTENSION {
string id
string name
}
%% Only 'storage' permission remains; 'tabs', 'activeTab', and 'notifications' are removed.
Class diagram for main.js after removing tab interactionsclassDiagram
class MainScript {
+refreshCacheButton
+refreshCacheClickHandler()
}
%% Previously, MainScript used chrome.tabs and chrome.tabs.sendMessage, which are now removed.
%% Now, only Materialize.toast and error logging remain in the handler.
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedansh-5 - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
I have made changes in this PR that are required to get our extension pass the review of chrome web store. Please take a look whenever you can @hpdang @Preeti9764 . |
LGTM @Preeti9764 could you please also check this? |
@vedansh-5 ,please fix this [obejct Object] in ui,when i click the refresh button , you mentioned this in pr#128 can you please check is it for this only or gitlab pr also cause i dont find it there.Thanks! |
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
@Preeti9764 I have fixed the above, could you check it again, I'll make a review again on the #128 for the same. |
@hpdang @vedansh-5 I have checked the bug is no more.Thanks! |
📝 Summary of Changes
In this PR I intend to remove the violating code for publishing the extension.
📸 Screenshots / Demo (if UI-related)
Add screenshots, video, or link to deployed preview if applicable
✅ Checklist
👀 Reviewer Notes
Add any special notes for the reviewer here
Summary by Sourcery
Remove disallowed tab-refresh code and restrict extension permissions to prepare for Chrome Webstore deployment
Enhancements: