-
Notifications
You must be signed in to change notification settings - Fork 90
Minor: Manual deploy #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: Manual deploy #223
Conversation
Reviewer's GuideThis PR introduces a new GitHub Actions workflow that enables manual deployment of the Chrome extension to the Chrome Web Store. It sets up Node.js, installs dependencies, packages the extension, and uses the official upload action with credentials stored in secrets. Flow diagram for manual deployment process via GitHub Actionsflowchart TD
A[Manual trigger via workflow_dispatch] --> B[Checkout repository]
B --> C[Set up Node.js]
C --> D[Install dependencies]
D --> E[Create ZIP file from src/]
E --> F[Upload ZIP to Chrome Web Store]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vedansh-5 - I've reviewed your changes - here's some feedback:
- Consider adding a build step (e.g., npm run build) before zipping to ensure your extension’s compiled assets are included.
- You can speed up manual deployments by caching your npm dependencies with actions/cache in the workflow.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a build step (e.g., npm run build) before zipping to ensure your extension’s compiled assets are included.
- You can speed up manual deployments by caching your npm dependencies with actions/cache in the workflow.
## Individual Comments
### Comment 1
<location> `.github/workflows/publish-chrome.yml:20` </location>
<code_context>
+ with:
+ node-version: "20"
+
+ - name: Install dependencies
+ run: npm install
+
+ - name: Create ZIP file
</code_context>
<issue_to_address>
Check if installing dependencies is necessary for the packaging and upload steps.
If dependencies aren't needed for packaging or upload, you can skip 'npm install' to improve workflow speed. If a build step is needed, make it explicit.
Suggested implementation:
```
- name: Create ZIP file
run: |
cd src
zip -r ../extension.zip . -x "*.DS_Store"
# This command zips the contents of src directory
```
If you actually need to build the extension (e.g., with a step like `npm run build`), add that step explicitly before the `Create ZIP file` step, and only then would you need to install dependencies. Otherwise, this change will speed up your workflow by skipping unnecessary dependency installation.
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
- name: Install dependencies | ||
run: npm install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Check if installing dependencies is necessary for the packaging and upload steps.
If dependencies aren't needed for packaging or upload, you can skip 'npm install' to improve workflow speed. If a build step is needed, make it explicit.
Suggested implementation:
- name: Create ZIP file
run: |
cd src
zip -r ../extension.zip . -x "*.DS_Store"
# This command zips the contents of src directory
If you actually need to build the extension (e.g., with a step like npm run build
), add that step explicitly before the Create ZIP file
step, and only then would you need to install dependencies. Otherwise, this change will speed up your workflow by skipping unnecessary dependency installation.
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
Signed-off-by: Vedansh Saini <77830698+vedansh-5@users.noreply.github.com>
📌 Fixes
Fixes #85
✅ Checklist
👀 Reviewer Notes
Add any special notes for the reviewer here
Summary by Sourcery
Add a GitHub Actions workflow to enable manual deployment of the Chrome extension by packaging the source and uploading it to the Chrome Web Store using action secrets.
Bug Fixes:
Enhancements:
CI:
Deployment: