Skip to content

fixed issue where large image would render in different env #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixed issue where large image would render in different env #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e394a92
fixed issue where large image would render in different env #80
Aryanamish Dec 2, 2022
42a1b0e
Merge branch 'master' into issue-#80
JackUrb Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,14 @@ class App extends React.Component {
// If we're in compare mode and recieve an update to an environment
// that is selected that isn't from the compare output, we need to
// reload the compare output
if(cmd.envID !== undefined && cmd.envID !== this.state.envID){
// If env of the window is not same to the current env then ignore it
break;
}
if(cmd.contentID === 'compare_legend' && this.state.envIDs.length < 2){
// if compare_legend comes and only one env is selected then ignore it
break;
}
if (this.state.envIDs.length > 1 && cmd.has_compare !== true) {
this.postForEnv(this.state.envIDs);
} else {
Expand Down
3 changes: 2 additions & 1 deletion py/visdom/utils/server_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,8 @@ def window(args):
"inflate": opts.get("inflate", True),
"width": opts.get("width"),
"height": opts.get("height"),
"contentID": get_rand_id(), # to detected updated windows
"envID": args.get("eid"),
"contentID": get_rand_id(), # to detected updated windows
}

if ptype == "image_history":
Expand Down