Fixed Functions, indentation, docstyle, docstrings, try-except . Included argparse checks, code optimizations #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TanweerulHaque |
|
Yes @SinghShreya05 , sorry for this error. Will be careful from the next time. |
|
PR is copy of #2 , Closing as multiple PRs not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indentation fixes, docstring style , file linting fixes.
Removed unnecessary imports in various files/directories.
Included valid parameter checks in "argparse" - valid directory check, valid file check, valid number of cores check in case of multiprocessing. It was added in all type of file which used "argparse" package.
Added "type - except" in various functions.
Changes made in "requirements.txt" as one can installed latest version of "pandas" and "numpy". Since there was no such type of function used by either of the two packages which could have gone a change in recent months. It's better to allow users to install any version >= what was there during development.
Code optimizations using list comprehensions, built in numpy methods etc.
Please let me know in case of errors or any changes required. Thank you.