Skip to content

fix: use vm.getBlockTimestamp for skip and rewind #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: use vm.getBlockTimestamp for skip and rewind #634

merged 1 commit into from
Dec 4, 2024

Conversation

xenide
Copy link
Contributor

@xenide xenide commented Dec 3, 2024

Given that during via-ir compilations, the block.timestamp variable might be distorted due to optimizations, the more correct way to obtain the block timestamp. See this discussion

mattsse
mattsse approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah this should use the (modified) timestamp

@mattsse mattsse merged commit 051fb65 into foundry-rs:master Dec 4, 2024
3 checks passed
@xenide xenide deleted the fix/use-vm-timestamp branch December 7, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xenide @mattsse @DaniPopes