Skip to content

Conversation

@Bilogweb3
Copy link
Contributor

@Bilogweb3 Bilogweb3 commented Nov 12, 2025

When parse_array receives no values, it now returns a properly typed DynSolValue::Array instead of a String. While both have identical ABI encoding, this fixes semantic correctness and makes the code match its comment and function name.

@0xrusowsky
Copy link
Contributor

can you add a test?

@Bilogweb3
Copy link
Contributor Author

@0xrusowsky empty string and empty array have identical ABI encoding, so tests pass with both old and new code.

The fix is still correct though:

  • parse_array should return Array, not String
  • Old comment was wrong ("Bytes" → actually returned String)
  • Integration tests already cover this (Env.t.sol lines 247-344)

If you still want me to add tests I can do that.

@DaniPopes
Copy link
Member

doesn't matter, it's the same

@DaniPopes DaniPopes closed this Nov 27, 2025
@github-project-automation github-project-automation bot moved this to Done in Foundry Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants