Fix determining version #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/setup-snfoundry into 31-fix-determining-version
…s/setup-snfoundry into 31-fix-determining-version
franciszekjob
commented
Jun 23, 2025
franciszekjob
commented
Jun 23, 2025
| } | ||
|
|
||
| async function determineVersion(version, toolVersionsPath, repo) { | ||
| version = version?.trim(); |
There was a problem hiding this comment.
note: It's trimmed by default
https://github.com/actions/toolkit/blob/683703c1149439530dcee7b8c5dbbfeec4104368/packages/core/src/core.ts#L151-L162
THenry14
reviewed
Jun 24, 2025
THenry14
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31
Fix handling of
starknet-foundry-versionandtool-versionsinputs - they now correctly determine the version to use.