Remove V2 labels #3037

ychiucco · 2025-11-28T14:42:44Z

Checklist before merging

I added an appropriate entry to CHANGELOG.md
I added logging to new code - if appropriate.
I merged main into the current branch.

github-actions · 2025-11-28T15:26:21Z

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
fractal_server/app/routes/admin/v2
job.py	$This PR doesn't change the number of statements in fractal_server/app/routes/admin/v2/job.py, which is 132.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/admin/v2/job.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/admin/v2/job.py, which is 99.43% (132/132).$	$In this PR, 30 new statements are added to fractal_server/app/routes/admin/v2/job.py, 30 of which are covered (100%).$
task_group_lifecycle.py	$This PR doesn't change the number of statements in fractal_server/app/routes/admin/v2/task_group_lifecycle.py, which is 105.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/admin/v2/task_group_lifecycle.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/admin/v2/task_group_lifecycle.py, which is 100% (105/105).$	$In this PR, 23 new statements are added to fractal_server/app/routes/admin/v2/task_group_lifecycle.py, 23 of which are covered (100%).$
fractal_server/app/routes/api/v2
__init__.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/__init__.py, which is 43.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/__init__.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/__init__.py, which is 100% (43/43).$	$In this PR, 42 new statements are added to fractal_server/app/routes/api/v2/__init__.py, 42 of which are covered (100%).$
dataset.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/dataset.py, which is 101.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/dataset.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/dataset.py, which is 100% (101/101).$	$In this PR, 23 new statements are added to fractal_server/app/routes/api/v2/dataset.py, 23 of which are covered (100%).$
job.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/job.py, which is 92.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/job.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/job.py, which is 100% (92/92).$	$In this PR, 24 new statements are added to fractal_server/app/routes/api/v2/job.py, 24 of which are covered (100%).$
status_legacy.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/status_legacy.py, which is 74.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/status_legacy.py, which is 5.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/status_legacy.py, which is 94.68% (69/74).$	$In this PR, 23 new statements are added to fractal_server/app/routes/api/v2/status_legacy.py, 23 of which are covered (100%).$
submit.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/submit.py, which is 112.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/submit.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/submit.py, which is 99.27% (112/112).$	$In this PR, 26 new statements are added to fractal_server/app/routes/api/v2/submit.py, 26 of which are covered (100%).$
task.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/task.py, which is 90.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/task.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/task.py, which is 100% (90/90).$	$In this PR, 22 new statements are added to fractal_server/app/routes/api/v2/task.py, 22 of which are covered (100%).$
task_collection.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/task_collection.py, which is 145.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/task_collection.py, which is 2.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/task_collection.py, which is 98.3% (143/145).$	$In this PR, 41 new statements are added to fractal_server/app/routes/api/v2/task_collection.py, 39 of which are covered (95.12%).$	282-283
task_group.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/task_group.py, which is 102.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/task_group.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/task_group.py, which is 99.26% (102/102).$	$In this PR, 25 new statements are added to fractal_server/app/routes/api/v2/task_group.py, 25 of which are covered (100%).$
task_group_lifecycle.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/task_group_lifecycle.py, which is 115.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/task_group_lifecycle.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/task_group_lifecycle.py, which is 100% (115/115).$	$In this PR, 37 new statements are added to fractal_server/app/routes/api/v2/task_group_lifecycle.py, 37 of which are covered (100%).$
workflow.py	$This PR doesn't change the number of statements in fractal_server/app/routes/api/v2/workflow.py, which is 110.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/routes/api/v2/workflow.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/routes/api/v2/workflow.py, which is 100% (110/110).$	$In this PR, 21 new statements are added to fractal_server/app/routes/api/v2/workflow.py, 21 of which are covered (100%).$
fractal_server/app/schemas/v2
__init__.py	$This PR doesn't change the number of statements in fractal_server/app/schemas/v2/__init__.py, which is 78.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/__init__.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/__init__.py, which is 100% (78/78).$	$In this PR, 70 new statements are added to fractal_server/app/schemas/v2/__init__.py, 70 of which are covered (100%).$
dataset.py	$This PR doesn't change the number of statements in fractal_server/app/schemas/v2/dataset.py, which is 24.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/dataset.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/dataset.py, which is 100% (24/24).$	$In this PR, 24 new statements are added to fractal_server/app/schemas/v2/dataset.py, 24 of which are covered (100%).$
dumps.py	$This PR doesn't change the number of statements in fractal_server/app/schemas/v2/dumps.py, which is 28.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/dumps.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/dumps.py, which is 100% (28/28).$	$In this PR, 32 new statements are added to fractal_server/app/schemas/v2/dumps.py, 32 of which are covered (100%).$
job.py	$This PR doesn't change the number of statements in fractal_server/app/schemas/v2/job.py, which is 60.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/job.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/job.py, which is 100% (60/60).$	$In this PR, 32 new statements are added to fractal_server/app/schemas/v2/job.py, 32 of which are covered (100%).$
task.py	$This PR doesn't change the number of statements in fractal_server/app/schemas/v2/task.py, which is 90.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/task.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/task.py, which is 100% (90/90).$	$In this PR, 24 new statements are added to fractal_server/app/schemas/v2/task.py, 24 of which are covered (100%).$
task_group.py	$This PR doesn't change the number of statements in fractal_server/app/schemas/v2/task_group.py, which is 73.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/task_group.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/task_group.py, which is 100% (73/73).$	$In this PR, 62 new statements are added to fractal_server/app/schemas/v2/task_group.py, 62 of which are covered (100%).$
workflow.py	$This PR doesn't change the number of statements in fractal_server/app/schemas/v2/workflow.py, which is 26.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/workflow.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/workflow.py, which is 100% (26/26).$	$In this PR, 36 new statements are added to fractal_server/app/schemas/v2/workflow.py, 36 of which are covered (100%).$
workflowtask.py	$This PR doesn't change the number of statements in fractal_server/app/schemas/v2/workflowtask.py, which is 63.$	$This PR doesn't change the number of statements missing coverage in fractal_server/app/schemas/v2/workflowtask.py, which is 0.$	$This PR doesn't change the coverage rate in fractal_server/app/schemas/v2/workflowtask.py, which is 100% (63/63).$	$In this PR, 43 new statements are added to fractal_server/app/schemas/v2/workflowtask.py, 43 of which are covered (100%).$
fractal_server/runner/v2
runner.py	$This PR doesn't change the number of statements in fractal_server/runner/v2/runner.py, which is 193.$	$This PR doesn't change the number of statements missing coverage in fractal_server/runner/v2/runner.py, which is 2.$	$This PR doesn't change the coverage rate in fractal_server/runner/v2/runner.py, which is 97.87% (191/193).$	$In this PR, 27 new statements are added to fractal_server/runner/v2/runner.py, 27 of which are covered (100%).$
runner_functions.py	$This PR doesn't change the number of statements in fractal_server/runner/v2/runner_functions.py, which is 192.$	$This PR doesn't change the number of statements missing coverage in fractal_server/runner/v2/runner_functions.py, which is 11.$	$This PR doesn't change the coverage rate in fractal_server/runner/v2/runner_functions.py, which is 92.08% (181/192).$	$In this PR, 22 new statements are added to fractal_server/runner/v2/runner_functions.py, 21 of which are covered (95.45%).$	171
fractal_server/tasks/v2/local
deactivate.py	$This PR doesn't change the number of statements in fractal_server/tasks/v2/local/deactivate.py, which is 89.$	$This PR doesn't change the number of statements missing coverage in fractal_server/tasks/v2/local/deactivate.py, which is 1.$	$This PR doesn't change the coverage rate in fractal_server/tasks/v2/local/deactivate.py, which is 98.13% (88/89).$	$In this PR, 24 new statements are added to fractal_server/tasks/v2/local/deactivate.py, 24 of which are covered (100%).$
delete.py	$This PR doesn't change the number of statements in fractal_server/tasks/v2/local/delete.py, which is 45.$	$This PR doesn't change the number of statements missing coverage in fractal_server/tasks/v2/local/delete.py, which is 1.$	$This PR doesn't change the coverage rate in fractal_server/tasks/v2/local/delete.py, which is 95.91% (44/45).$	$In this PR, 23 new statements are added to fractal_server/tasks/v2/local/delete.py, 22 of which are covered (95.65%).$	45
fractal_server/tasks/v2/ssh
delete.py	$This PR doesn't change the number of statements in fractal_server/tasks/v2/ssh/delete.py, which is 51.$	$This PR doesn't change the number of statements missing coverage in fractal_server/tasks/v2/ssh/delete.py, which is 2.$	$This PR doesn't change the coverage rate in fractal_server/tasks/v2/ssh/delete.py, which is 93.22% (49/51).$	$In this PR, 22 new statements are added to fractal_server/tasks/v2/ssh/delete.py, 21 of which are covered (95.45%).$	81
Project Total

The report is truncated to 25 files out of 61. To see the full report, please visit the workflow summary page.

_{This report was generated by python-coverage-comment-action}

fractal_server/app/schemas/v2/manifest.py

remove V2 from fractal_server/app/schemas/

eefd65c

ychiucco linked an issue Nov 28, 2025 that may be closed by this pull request

Remove "V2" labels #3004

Closed

This comment was marked as off-topic.

Sign in to view

ychiucco added 5 commits November 28, 2025 15:49

change remaining non-db classes with V2

1ae5232

rollback Manifest and TaskManifest to V2

ac70ea6

remove v2 from function names

bcf055d

fix test not api

3a272c1

fix another test not api

41a8957

ychiucco added 4 commits November 28, 2025 16:39

fixture names leftovers

850fbca

grep all '_v2' and 'jobsV2'

ace7225

small fixes

5b90d3b

comments and logs

6a61370

tcompa self-requested a review December 1, 2025 09:02

tcompa reviewed Dec 1, 2025

View reviewed changes

fractal_server/app/schemas/v2/manifest.py Outdated Show resolved Hide resolved

tcompa reviewed Dec 1, 2025

View reviewed changes

fractal_server/app/schemas/v2/manifest.py Show resolved Hide resolved

tcompa added 4 commits December 1, 2025 10:33

revert some changes

63e48f8

fix test

842b38f

CHANGELOG [skip ci]

f9ad128

Merge branch 'main' into 3004-remove-v2-labels

b1bdbd9

tcompa marked this pull request as ready for review December 1, 2025 09:36

tcompa merged commit df1eace into main Dec 1, 2025
25 checks passed

tcompa deleted the 3004-remove-v2-labels branch December 1, 2025 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove V2 labels #3037

Remove V2 labels #3037

Uh oh!

ychiucco commented Nov 28, 2025 •

edited by tcompa

Loading

Uh oh!

This comment was marked as off-topic.

github-actions bot commented Nov 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Remove V2 labels #3037

Remove V2 labels #3037

Uh oh!

Conversation

ychiucco commented Nov 28, 2025 • edited by tcompa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist before merging

Uh oh!

This comment was marked as off-topic.

github-actions bot commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ychiucco commented Nov 28, 2025 •

edited by tcompa

Loading

github-actions bot commented Nov 28, 2025 •

edited

Loading