Reduce implementation complexity #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started reviewing TobikoData#4751 again but quickly realised there were some more fundamental problems. Namely, a lot of things were implemented that did not need to exist and I figured that there would be a lot of back-and-forth that would ultimately just end up getting fed into Claude and not actually addressing the underlying problems.
So this PR does the following:
CatalogSupport.FULL_SUPPORT
toCatalogSupport.REQUIRES_SET_CATALOG
because it seems far more operations than not need the catalog to be set, including queryingINFORMATION_SCHEMA
FabricEngineAdapter
constructorThe result passes our integration test suite but I didn't run it against an actual project.
@fresioAS if you have something locally do you mind doublechecking it?