fix: htmlSet error in modal #127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanneculai can you take a look at this? |
jyyan
added a commit
to jyyan/vue-froala-wysiwyg
that referenced
this pull request
Jan 15, 2020
|
Does anyone know who's maintaining this? We'd like to get this merged/resolved. I'm tired of fielding "there is this mystery error in the console, fix it!" requests. |
|
Is this going to be merged? |
|
I have also raised support ticket for the same. |
|
@kapil2704 can you look at this. |
Merged
|
Closing this MR as changes are already merged with #157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details: #107
Maybe also related to #87 but didn't check with v-if
Also there is one more PR open maybe for the same thing I am trying to do (but I did go with small change), also look at that: #98.
My error case
Error was coming for recreating editor because in initEvents it keeps reference of old VueComponent and that even again calls again the new instance is created but it gets _editor null because we destroyed it.