Patch Component render function #416
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…captures state that state is stale. This is the case because we never change the render function - even tho it's instantiated. This change makes it possible to access outer state and re-render when captured state changes. This is still a prototype.
… requires not using an FSharp function as getting the address of a function type is prevented by the compiler. I guess casting the function to an object might have also worked here. - simplify bindings by passing in the RenderFunctionProperty
JaggerJo
changed the title
… functions. This works but is still a bit messy.
Component: plain old component, unchanged from master ClosureComponent: component that works well with render function that captures state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation: If the render function of a component closes over/captures
state that state is stale. This is the case because we never change the render function - even tho it's instantiated.
This change makes it possible to access outer state and re-render when captured state changes.
This is still a prototype.