Skip to content

Conversation

@baest
Copy link

@baest baest commented Jul 11, 2025

Implements #202. Missing tests or doc changes. I can contribute those.

@garu
Copy link
Owner

garu commented Jul 12, 2025

Hey @baest! Thank you using Data-Printer and for the thoughtful and relevant patch! I have only a few simple requests before merging:

  1. Could you please update the code so it looks for XDG_CONFIG_HOME before the user's home dir? My understanding is that XDG_CONFIG_HOME should take priority when it comes to finding config files.
  2. To avoid ambiguity and confusion, could you please keep the original .dataprinter name? I know it makes little sense inside XDG, but I want people to be able to mv it around without worrying about name changes. So the full path would be File::Spec->catfile($ENV{XDG_CONFIG_HOME}, 'dataprinter', '.dataprinter');
  3. Tests and documentation are most welcome. In particular, tests should be under t/017-rc_file.t but it's ok if you rather delegate them to me, just let me know.
  4. Please add yourself to the "CONTRIBUTOR"s list!

Cheers!

@baest
Copy link
Author

baest commented Jul 13, 2025

Hi @garu Thanks for the quick reply!

  1. Yes of course. That was actually what I wanted originally but thought that this would be more easily accepted.
  2. Sure I can do that. I just want to note that this is against normal standard. https://wiki.archlinux.org/title/XDG_Base_Directory#Supported list a bunch of supported applications and none of them it seems use dot file notation inside XDG. That said, I see your argument and just want to raise this note.
  3. I will give it a stab, did find 017-rc_file.t before sending the PR, but doing the test was a bit more involved than what time allowed originally.
  4. Sure ;-)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants