Remove ogre2 overlay system #1175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
ahcorde
approved these changes
Sep 23, 2025
j-rivero
added a commit
that referenced
this pull request
Sep 23, 2025
Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
j-rivero
added a commit
that referenced
this pull request
Sep 24, 2025
This is mainly a port of #1175 to be activated under the parameter `USE_OGRE2_OVERLAY` enabled by default. Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
j-rivero
added a commit
that referenced
this pull request
Sep 24, 2025
This is mainly a port of #1175 to be activated under the parameter `USE_OGRE2_OVERLAY` enabled by default. Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
2 tasks
3 tasks
j-rivero
added a commit
that referenced
this pull request
Oct 1, 2025
* Exclude OGRE2 Overlay using a CMake argument (gz-rendering9) This is mainly a port of #1175 to be activated under the parameter `USE_OGRE2_OVERLAY` enabled by default. --------- Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com> Co-authored-by: Silvio Traversaro <silvio@traversaro.it>
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
* Exclude OGRE2 Overlay using a CMake argument (gz-rendering9) This is mainly a port of #1175 to be activated under the parameter `USE_OGRE2_OVERLAY` enabled by default. --------- Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com> Co-authored-by: Silvio Traversaro <silvio@traversaro.it> (cherry picked from commit bb0e866) # Conflicts: # Changelog.md
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Related issue: OGRECave/ogre-next#541
Summary
We create the ogre2 overlay system but don't really use it. Given that it's now causing an issue on mac (OGRECave/ogre-next#541), this PR completely removes the dependency on the ogre2 Overlay component in
main.The alternative considered was to only remove the overlay system on macOS because of the aforementioned issue, and go through the tick-tock deprecation cycle on linux and windows. However, given that there is only one public API function for accessing the overlay system and it was always marked
\internal, I decided to remove it on all platforms.Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.