ReadonlyArray Difference Prefer Non-Deprecated #1826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer Non-Deprecated Function Signature for ReadonlyArray Difference
Currently there two function signatures for the difference function in the ReadonlyArray module and one is deprecated. Typescript seems to give preference to the deprecated signature as shown here:
This PR changes the order of the signatures, prioritizing the non-deprecated signature:
Before submitting a pull request, please make sure the following is done:
master.npm installin the repository root.npm test).Note. If you've fixed a bug please link the related issue or, if missing, open an issue before sending a PR.
#1804
Note. If you find a typo in the documentation, make sure to modify the corresponding source (docs are generated).
Note. If you want to send a PR related to
fp-ts@1.xplease create your branch from1.x