Fix: Support negative parameters in Affine Cipher operations #2121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Affine Cipher encrypt/decrypt operations were restricted to positive integers only for parameters
a
andb
, preventing correct decryption of ciphertexts that require negative parameters.Example:
szzyfimhyzd
a=17, b=-8
affineshift
Solution
Modified the parameter validation regex in
src\core\lib\Ciphers.mjs:31
to accept both positive and negative integers:Before:
After:
And maintains all existing mathematical constraints (gcd(a,26)=1)