Add query_graphql_json methods #813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
force-pushed
the
query_graphql
branch
3 times, most recently
from
fb2fe7a to
6efc56f
Compare
|
Tests are failing because gel nightly is broken so doesn't support the feature yet |
elprans
reviewed
Aug 4, 2025
gel/abstract.py
Outdated
| @@ -597,6 +597,31 @@ def query_sql( | |||
| ) | |||
| ) | |||
|
|
|||
| def query_graphql_json( | |||
| self, | |||
| query: str | Queryable[_T_ql], | |||
There was a problem hiding this comment.
The Queryable protocol is for EdgeQL, so these should only accept str.
There is not a non-JSON method, since making that work will be tricky for annoying reasons, but I want to have it eventually.
msullivan
force-pushed
the
query_graphql
branch
from
c689f02 to
eca2cb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is not a non-JSON method, since making that work will be tricky
for annoying reasons, but I want to have it eventually.