Apply generate config from env #815
Merged
+158
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I should probably reuse Python stdlib traceback formatting) |
1st1
reviewed
Jul 31, 2025
1st1
reviewed
Jul 31, 2025
1st1
reviewed
Jul 31, 2025
1st1
approved these changes
Jul 31, 2025
1st1
reviewed
Jul 31, 2025
1st1
requested changes
Jul 31, 2025
I think what you did looks nice! |
1st1
reviewed
Jul 31, 2025
1st1
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse and apply generate config from environment variables, see also geldata/gel-cli#1703.
This PR adds the infrastructure to parse generate config envs and report errors, as well as 2 configs for the
modelsgenerator:no_cache: boolean, the same as--no-cacheoutput: string, the same as--outputParse error looks like: