Skip to content

PR: Restore taskmanagers wait loop #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

PR: Restore taskmanagers wait loop #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions qtapputils/managers/taskmanagers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
# ---- Standard imports
from collections import OrderedDict
import uuid
from time import sleep

# ---- Third party imports
from qtpy.QtCore import QObject, QThread, Signal
Expand Down Expand Up @@ -203,11 +204,13 @@ def _run_pending_tasks(self):

# Even though the worker has executed all its tasks,
# we may still need to wait a little for it to stop properly.
try:
qtwait(lambda: not self._thread.isRunning(), timeout=10)
except TimeoutError:
print("Error: unable to stop {}'s working thread.".format(
self.__class__.__name__))
i = 0
while self._thread.isRunning():
sleep(0.1)
i += 1
if i > 100:
print("Error: unable to stop {}'s working thread.".format(
self.__class__.__name__))

self._running_tasks = self._pending_tasks.copy()
self._pending_tasks = []
Expand Down
Loading