Skip to content

feat: drop support for symfony < 6 #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norkunas merged 1 commit into from
Dec 23, 2025
Merged

feat: drop support for symfony < 6 #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
"php": "^8.1",
"geocoder-php/plugin": "^1.5",
"php-http/discovery": "^1.14",
"symfony/console": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/framework-bundle": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/options-resolver": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/console": "^6.4 || ^7.0 || ^8.0",
"symfony/framework-bundle": "^6.4 || ^7.0 || ^8.0",
"symfony/options-resolver": "^6.4 || ^7.0 || ^8.0",
Comment on lines +20 to +22
Copy link

@coderabbitai coderabbitai bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check for CHANGELOG and UPGRADE documentation files

echo "=== Checking for CHANGELOG files ==="
fd -t f -i 'changelog' -E vendor -E node_modules 2>/dev/null || echo "No CHANGELOG found"

echo -e "\n=== Checking for UPGRADE files ==="
fd -t f -i 'upgrade' -E vendor -E node_modules 2>/dev/null || echo "No UPGRADE found"

echo -e "\n=== Checking for README files ==="
fd -t f 'README*' -E vendor -E node_modules 2>/dev/null | head -10

echo -e "\n=== Examining composer.json structure ==="
head -100 composer.json

Repository: geocoder-php/BazingaGeocoderBundle

Length of output: 3397

🏁 Script executed:

#!/bin/bash
# Check CHANGELOG.md content - look for Symfony 5.4 removal documentation
echo "=== CHANGELOG.md content (first 150 lines) ==="
head -150 CHANGELOG.md

echo -e "\n=== Checking for Unreleased section or version 6.0 ==="
grep -A 20 -i "unreleased\|^## \[6\|^## 6" CHANGELOG.md | head -40

echo -e "\n=== Checking README.md for version requirements ==="
grep -i "symfony\|version\|requirement" README.md | head -20

Repository: geocoder-php/BazingaGeocoderBundle

Length of output: 2816

🏁 Script executed:

#!/bin/bash
# Check for more comprehensive CHANGELOG content, especially looking for 6.0 or unreleased entries
echo "=== Full CHANGELOG.md (checking for version 6.0 or Unreleased entries) ==="
grep -i "^## \|^# " CHANGELOG.md

echo -e "\n=== Checking line count and structure of CHANGELOG.md ==="
wc -l CHANGELOG.md

echo -e "\n=== Check for any mentions of Symfony 5 removal ==="
grep -i "symfony 5\|remove.*symfony\|drop.*symfony" CHANGELOG.md

echo -e "\n=== README.md - full check for requirements/version info ==="
cat README.md | head -80

Repository: geocoder-php/BazingaGeocoderBundle

Length of output: 3057

Document the breaking change in CHANGELOG.md before merging.

This PR removes Symfony 5.4 support, which is a breaking change that impacts users currently on older versions. The version 6.0 entry must be added to CHANGELOG.md documenting the minimum Symfony version requirement change from ^5.4 to ^6.4. Consider creating an UPGRADE.md guide to help users migrate from version 5.x to 6.0.

🤖 Prompt for AI Agents 
In composer.json around lines 20 to 22, the dependency change removes Symfony
5.4 support which is a breaking change; update CHANGELOG.md by adding a "v6.0"
(or "6.0.0") entry that explicitly documents the minimum Symfony requirement
change from ^5.4 to ^6.4 and describes the impact for users, and create an
UPGRADE.md (or add a section) with concise migration steps and notable
incompatibilities for upgrading from 5.x to 6.0; commit both files alongside
this PR before merging.

"willdurand/geocoder": "^4.6|^5.0"
},
"require-dev": {
Expand Down Expand Up @@ -55,17 +55,17 @@
"geocoder-php/yandex-provider": "^4.6",
"nyholm/nsa": "^1.3",
"nyholm/psr7": "^1.8",
"nyholm/symfony-bundle-test": "^2.0 || ^3.0",
"nyholm/symfony-bundle-test": "^3.1",
"phpstan/phpstan": "^1.9.2",
"psr/http-client": "^1.0",
"psr/simple-cache": "^1.0 || ^2.0 || ^3.0",
"symfony/cache": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/config": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/http-client": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/phpunit-bridge": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/validator": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/var-exporter": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/yaml": "^5.4 || ^6.4 || ^7.0 || ^8.0"
"symfony/cache": "^6.4 || ^7.0 || ^8.0",
"symfony/config": "^6.4 || ^7.0 || ^8.0",
"symfony/http-client": "^6.4 || ^7.0 || ^8.0",
"symfony/phpunit-bridge": "^6.4 || ^7.0 || ^8.0",
"symfony/validator": "^6.4 || ^7.0 || ^8.0",
"symfony/var-exporter": "^6.4 || ^7.0 || ^8.0",
"symfony/yaml": "^6.4 || ^7.0 || ^8.0"
},
"autoload": {
"psr-4": {
Expand Down