Skip to content

fix: preserve BetterAuth options type for inferAdditionalFields type inference #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: preserve BetterAuth options type for inferAdditionalFields type inference #141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7246015
fix: preserve BetterAuth options type in CreateAuth and getStaticAuth…
richardsolomou Oct 23, 2025
6911663
fix whitespace
richardsolomou Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/client/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
} from "convex/server";
import { type GenericId, Infer, v } from "convex/values";
import { convexAdapter } from "./adapter";
import { AdapterInstance, betterAuth } from "better-auth";
import { AdapterInstance, betterAuth, type Auth, type BetterAuthOptions } from "better-auth";
import { asyncMap } from "convex-helpers";
import { partial } from "convex-helpers/validators";
import {
Expand All @@ -44,16 +44,19 @@ export type CreateAdapter = <Ctx extends GenericCtx<GenericDataModel>>(
ctx: Ctx
) => AdapterInstance;

export type CreateAuth<DataModel extends GenericDataModel> =
| ((ctx: GenericCtx<DataModel>) => ReturnType<typeof betterAuth>)
| ((
ctx: GenericCtx<DataModel>,
opts?: { optionsOnly?: boolean }
) => ReturnType<typeof betterAuth>);
export type CreateAuth<
DataModel extends GenericDataModel,
Options extends BetterAuthOptions = any
> =
| ((ctx: GenericCtx<DataModel>) => Auth<Options>)
| ((ctx: GenericCtx<DataModel>, opts?: { optionsOnly?: boolean }) => Auth<Options>);

export const getStaticAuth = <DataModel extends GenericDataModel>(
createAuth: CreateAuth<DataModel>
) => {
export const getStaticAuth = <
DataModel extends GenericDataModel,
Options extends BetterAuthOptions = any
>(
createAuth: CreateAuth<DataModel, Options>
): Auth<Options> => {
return createAuth({} as any, { optionsOnly: true });
};

Expand Down