Skip to content

Make api.create able to run with one specific creator plugin #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Make api.create able to run with one specific creator plugin #531

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c8886ea
Make `api.create` able to run with one specific creator plugin
davidlatwe Mar 10, 2020
ebcb78c
Reverse if-statement for better readability
davidlatwe Sep 30, 2020
11a319a
Fix non-class family input
davidlatwe Sep 30, 2020
69d99b2
Add test
davidlatwe Sep 30, 2020
83b72ab
Fix test
davidlatwe Sep 30, 2020
301ec73
Skip testing vendorized avalon/style module
davidlatwe Sep 30, 2020
ce8a24e
Fix mock host
davidlatwe Sep 30, 2020
ccb393c
Improve test to reflect exact result of #531
davidlatwe Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions avalon/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,12 +878,13 @@ def create(name, asset, family, options=None, data=None):

host = registered_host()

plugins = list()
for Plugin in discover(Creator):
has_family = family == Plugin.family
if isinstance(family, str):
Plugins = [P for P in discover(Creator) if family == P.family]
else:
Plugins = [family]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got me wondering for a second what is going on here. Should this maybe be in reverse, something like this:

    if isinstance(family, Creator):
        # Allow passing in a specific Creator to run only that plug-in
        Plugins = [family]
    else:
        Plugins = [P for P in discover(Creator) if family == P.family]

Also makes the check more explicit to it being a Creator plug-in.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point !
Changed in commit ebcb78c
( note that the family has now changed to also accept a subclass of api.Creator, so it should be using issubclass ;) )

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!


if not has_family:
continue
plugins = list()
for Plugin in Plugins:

Plugin.log.info(
"Creating '%s' with '%s'" % (name, Plugin.__name__)
Expand Down
4 changes: 2 additions & 2 deletions avalon/tools/creator/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,13 +436,13 @@ def on_create(self):

subset_name = result.text()
asset = asset.text()
family = item.data(FamilyRole)
Plugin = item.data(PluginRole)
use_selection = self.data["Use Selection Checkbox"].isChecked()

try:
api.create(subset_name,
asset,
family,
Plugin,
options={"useSelection": use_selection})

except NameError as e:
Expand Down