-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: enhance ui for oss upgrade #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe update notification modal in the NavBar component was adjusted by increasing its width and modifying the styling of the Tabs component within it. The Tabs' centered alignment was removed, and a left margin was added to improve layout spacing. Changes
Estimated code review effort1 (~2 minutes) Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
src/components/dashboard/NavBar.tsx (1)
268-275
: Replace fixedwidth: 700
with a responsive valueA hard-coded pixel width will overflow on smaller viewports (e.g., mobile devices). MUI’s
sx
supports breakpoint-based objects, so you can make the modal adapt without losing the intended max size.- width: 700, + width: { xs: '90vw', sm: 600, md: 700 },This keeps the large desktop size while capping the modal at 90 % of the viewport width on phones.
🧹 Nitpick comments (1)
src/components/dashboard/NavBar.tsx (1)
291-296
: Left-align Tabs via flex rather than manualmarginLeft
Padding with a magic number (
30px
) can drift as the modal layout evolves and may break in RTL languages. Use container flex alignment or theTab
sx
prop to control positioning instead.- <Tabs - value={tab} - onChange={handleUpdateTabChange} - sx={{ marginTop: 2, marginBottom: 2, marginLeft: '30px' }} + <Tabs + value={tab} + onChange={handleUpdateTabChange} + sx={{ mt: 2, mb: 2, pl: 3 }} // padding instead of exterior margin >Alternatively, wrap the tab bar in a
<Box display="flex" justifyContent="flex-start">
and drop manual spacing.
Summary by CodeRabbit