-
-
Notifications
You must be signed in to change notification settings - Fork 227
fix: protect UnsampledTransaction against double-Dispose
#4722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version6 #4722 +/- ##
===========================================
Coverage ? 73.26%
===========================================
Files ? 480
Lines ? 17433
Branches ? 3440
===========================================
Hits ? 12772
Misses ? 3815
Partials ? 846 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexsohn1126
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of the tests that are added seems to look for the double-dispose use case that this PR is trying to prevent.
Maybe something like DoubleDispose_DoseNothing?
The test |
Fixes #4719
Follow-up to #4717.
Merge into
version6branch after merging #4717.Mimicking implementation of
Sentry.TransactionTracer.#skip-changelog