Skip to content

Conversation

@Flash0ver
Copy link
Member

@Flash0ver Flash0ver commented Nov 11, 2025

Fixes #4719


Follow-up to #4717.
Merge into version6 branch after merging #4717.

Mimicking implementation of Sentry.TransactionTracer.


#skip-changelog

@Flash0ver Flash0ver self-assigned this Nov 11, 2025
@Flash0ver Flash0ver linked an issue Nov 11, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (version6@6a67f5e). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff             @@
##             version6    #4722   +/-   ##
===========================================
  Coverage            ?   73.26%           
===========================================
  Files               ?      480           
  Lines               ?    17433           
  Branches            ?     3440           
===========================================
  Hits                ?    12772           
  Misses              ?     3815           
  Partials            ?      846           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from fix/unsampled-memory-leak to version6 November 11, 2025 21:12
@Flash0ver Flash0ver marked this pull request as ready for review November 12, 2025 03:10
Copy link
Member

@alexsohn1126 alexsohn1126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the tests that are added seems to look for the double-dispose use case that this PR is trying to prevent.

Maybe something like DoubleDispose_DoseNothing?

@jamescrosswell jamescrosswell merged commit ffe3780 into version6 Nov 12, 2025
31 checks passed
@jamescrosswell jamescrosswell deleted the fix/unsampled-finish-dispose branch November 12, 2025 21:07
@Flash0ver
Copy link
Member Author

Flash0ver commented Nov 17, 2025

None of the tests that are added seems to look for the double-dispose use case that this PR is trying to prevent.

Maybe something like DoubleDispose_DoseNothing?

The test UnsampledTransactionTests.Dispose_Finished_DoesNothing does verify that: when Disposing (or Finishing) a Finished (or Disposed) UnsampledTransaction again, a Hub-member was only invoked once.
I wanted to keep both the naming as well as the behavior of the test consistent with TransactionTracer/TransactionTracerTests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finish Method Executes Redundantly

4 participants