-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(deps): Bump OpenTelemetry instrumentations #18239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
44bdc0e to
65edd0c
Compare
size-limit report 📦
|
c1de527 to
9980e4d
Compare
timfish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest @opentelemetry/instrumentation now uses import-in-the-middle v2 and require-in-the-middle v8.
These need updating wherever we have them as dependencies and then I guess the bundle impact might be reduced to zero!
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Bumping OpenTelemetry instrumentations is an important but tedious task, all instrumentations have to be bumped in lockstep across the codebase. That includes easy to miss dev-packages and third party instrumentations like prisma's. This command should make it easier to do that. Example of a PR that was kicked off with this command: #18239
1a1d8fc to
e435f4e
Compare
dev-packages/e2e-tests/test-applications/node-core-express-otel-v2-custom-sampler/package.json
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-otel-without-tracing/package.json
Show resolved
Hide resolved
d101f1a to
fb89424
Compare
- Bump @opentelemetry/instrumentation from 0.204.0 to 0.208.0 - Bump @opentelemetry/instrumentation-amqplib from 0.51.0 to 0.55.0 - Bump @opentelemetry/instrumentation-aws-sdk from 0.59.0 to 0.64.0 - Bump @opentelemetry/instrumentation-connect from 0.48.0 to 0.52.0 - Bump @opentelemetry/instrumentation-dataloader from 0.22.0 to 0.26.0 - Bump @opentelemetry/instrumentation-express from 0.53.0 to 0.57.0 - Bump @opentelemetry/instrumentation-fs from 0.24.0 to 0.28.0 - Bump @opentelemetry/instrumentation-generic-pool from 0.48.0 to 0.52.0 - Bump @opentelemetry/instrumentation-graphql from 0.52.0 to 0.56.0 - Bump @opentelemetry/instrumentation-hapi from 0.51.0 to 0.55.0 - Bump @opentelemetry/instrumentation-http from 0.204.0 to 0.208.0 - Bump @opentelemetry/instrumentation-ioredis from 0.52.0 to 0.56.0 - Bump @opentelemetry/instrumentation-kafkajs from 0.14.0 to 0.18.0 - Bump @opentelemetry/instrumentation-knex from 0.49.0 to 0.53.0 - Bump @opentelemetry/instrumentation-koa from 0.52.0 to 0.57.0 - Bump @opentelemetry/instrumentation-lru-memoizer from 0.49.0 to 0.53.0 - Bump @opentelemetry/instrumentation-mongodb from 0.57.0 to 0.61.0 - Bump @opentelemetry/instrumentation-mongoose from 0.51.0 to 0.55.0 - Bump @opentelemetry/instrumentation-mysql from 0.50.0 to 0.54.0 - Bump @opentelemetry/instrumentation-mysql2 from 0.51.0 to 0.55.0 - Bump @opentelemetry/instrumentation-nestjs-core from 0.50.0 to 0.55.0 - Bump @opentelemetry/instrumentation-pg from 0.57.0 to 0.61.0 - Bump @opentelemetry/instrumentation-redis from 0.53.0 to 0.57.0 - Bump @opentelemetry/instrumentation-tedious from 0.23.0 to 0.27.0 - Bump @opentelemetry/instrumentation-undici from 0.15.0 to 0.19.0 - Bump @prisma/instrumentation from 6.15.0 to 6.19.0
- Bump @opentelemetry/context-async-hooks from ^2.1.0 to ^2.2.0 - Bump @opentelemetry/core from ^2.1.0 to ^2.2.0 - Bump @opentelemetry/resources from ^2.1.0 to ^2.2.0 - Bump @opentelemetry/sdk-trace-base from ^2.1.0 to ^2.2.0 - Bump @opentelemetry/sdk-trace-node from ^2.1.0 to ^2.2.0 Added ^2.2.0 as peer dependency option for core OpenTelemetry packages in @sentry/node-core and @sentry/opentelemetry to support the latest OpenTelemetry SDK while maintaining backward compatibility with v1.30.1 and v2.1.0.
fb89424 to
265a630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 concerns. rest looks good (CI is failing though)
|
|
||
| // Inline EventEmitter interface to avoid Node.js module dependency | ||
| // This prevents Node.js type leaks in edge runtime environments | ||
| interface EventEmitter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: is this intended to be in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vendored these in because the build was failing. This being the edge-runtime I guess it kind of makes sense not to import anything from node modules. I don't know why this wasn't an issue before.
OTOH types don't make it into run time so.... kind of weird all in all.
|
|
||
| // Inline AsyncLocalStorage interface to avoid Node.js module dependency | ||
| // This prevents Node.js type leaks in edge runtime environments | ||
| interface AsyncLocalStorage<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: is this intended to be in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same answer as above.
057017e to
edc5083
Compare
This PR bumps OpenTelemetry instrumentations and SDK packages to their latest versions.
Dependency Updates:
Closes: #18178