POtel implementation base branch (aka SDK 3.0.0) #3152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
potel-base
branch
2 times, most recently
from
f7f153c to
28effd6
Compare
sl0thentr0py
force-pushed
the
potel-base
branch
2 times, most recently
from
16f9341 to
951477f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3152 +/- ##
==========================================
- Coverage 84.85% 84.85% -0.01%
==========================================
Files 156 158 +2
Lines 16110 16093 -17
Branches 2740 2564 -176
==========================================
- Hits 13670 13655 -15
+ Misses 1651 1648 -3
- Partials 789 790 +1
|
szokeasaurusrex
force-pushed
the
potel-base
branch
from
d4b1d00 to
4428ee9
Compare
antonpirker
changed the title
Make sure OK status is set, only when there has not been a error status set before.
Make sure there is a transaction name
Without this, internal otel logs (especially `logger.exception`s) will show up as events / breadcrumbs in the payload.
Merging `master` into `potel-base`, done in a PR because there have been some changes needed to the `span.name` setter to make it work for potel.
…4682) Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
Seems like some `before_send`s out there might assume tags without safe access as we found out during dogfooding.
The timeout in the AWS Lambda (and GCP, by extension) timeout warning is wrong, remove it and slightly rephrase. This is on `potel-base` since it breaks grouping. (Even just removing the number from the original message, without modifying it further, causes regrouping. Since that's the case I took the liberty to update the message a bit more.) Fixes #4629
`exclude_span_origins` and `only_as_child_span` were missing from the repo migration guide And fixing some wording
Add an async span context manager to allow for cleaner nesting in async code. Currently only delegates to the synchronous context manager. Fixes GH-2007
* DONT USE context manager since we're doing manual span management
we need to call the original function first for `db_params` to be correctly populated in the generator case (see diff without whitespace)
Clarified the async transport option details in the changelog.
Update the migration guide for 3.0 to include information on the async transport and context manager --------- Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
We are moving away from Spotlight's overlay mode with its new versions so removing this integration from the SDK too. Ref getsentry/spotlight#891
Making the HTTP2 transport the default when `h2` and `httpcore` packages are installed. We've been testing this on Sentry SaaS for a while without any issues. We should promote installing the SDK as `sentry-sdk[http2]` for this to be picked up though. Since we still have to support Python 3.7 and `h2` not being supported there, we cannot install it by default and use HTTP2 directly. --------- Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
antonpirker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
update_current_spanto SDK 3 #4679MAX_EVENT_BYTES#4630only_if_parenttoonly_as_child_span#4617scope.span =setter and make surescope.spanreference is correct in context manager regardless of source of span #4439SPANDATAconsistent in AI integrations.` #4376add_atttachment. #4360set_measurement#4333propagate_scope=FalseinThreadingIntegration#4310Scope.root_spanlogic #4274Scope.root_span#4273LoggingIntegrationto Sentry by default #4300integrations/opentelemetry/#4277integrations/opentelemetry/#4276integrations/opentelemetry/#4272integrations/opentelemetry/#4260integrations/opentelemetry/#4259integrations/opentelemetry/#4258cache_spansby default #3994start_spanfail if unsupported args are provided #4201Span.set_data()#4261sample_randto POTel #4106propagate_traces#4206warningsmodule for deprecation messagse. #4180sample_rateupdate topotel-base#4069SystemExit(0)not as a span status of 'internal_error' #4094use_scope#3851None#3816only_if_parentoption to POTelSpan and use it in integrations #3748_serialize_span_attributeintoset_attribute#3732subprocessbreadcrumbs frommaybe_create_breadcrumbs_from_spanto integration. #3637addto trace state if key does not exist #3645op. #3628make aws lambda layer#3586use_scope,use_isolation_scope#3522use_scope,use_isolation_scope#3500OpenTelemetryIntegrationtoDEFAULT_INTEGRATIONS#3471activeflag onPOTelSpan#3470start_transaction#3379Huband related code for good. #3446Simple test
References
startSpan& friendsstart_span& friendsMisc
In OTel, this:
is equivalent to