Skip to content

Conversation

@constantinius
Copy link
Contributor

@constantinius constantinius commented Oct 20, 2025

@linear
Copy link

linear bot commented Oct 20, 2025

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 82.00000% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.95%. Comparing base (e9738f6) to head (aa6d124).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/mcp.py 79.63% 28 Missing and 17 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4964      +/-   ##
==========================================
- Coverage   83.96%   83.95%   -0.02%     
==========================================
  Files         165      166       +1     
  Lines       17085    17335     +250     
  Branches     3001     3054      +53     
==========================================
+ Hits        14346    14554     +208     
- Misses       1839     1866      +27     
- Partials      900      915      +15     
Files with missing lines Coverage Δ
sentry_sdk/consts.py 99.40% <100.00%> (+0.05%) ⬆️
sentry_sdk/integrations/__init__.py 87.01% <ø> (ø)
sentry_sdk/integrations/mcp.py 79.63% <79.63%> (ø)

... and 1 file with indirect coverage changes

@constantinius constantinius marked this pull request as ready for review October 21, 2025 09:08
@constantinius constantinius requested a review from a team as a code owner October 21, 2025 09:08
@constantinius constantinius requested a review from a team October 21, 2025 09:08
@linear
Copy link

linear bot commented Oct 21, 2025

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great overall! Left a few comments. Will take it for a spin and report back.

Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
cursor[bot]

This comment was marked as outdated.

@cursor
Copy link

cursor bot commented Oct 23, 2025

Bug: Prompt Handler Argument Merge Order Issue

In _prepare_handler_data, the arguments dictionary for prompt handlers has an incorrect merge order. This allows a user-provided "name" argument to unintentionally overwrite the actual handler_name, leading to misleading mcp.prompt.name span data.

Fix in Cursor Fix in Web

@constantinius constantinius merged commit 2944936 into master Oct 23, 2025
123 of 124 checks passed
@constantinius constantinius deleted the constantinius/feat/integrations/mcp-integration branch October 23, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants