Skip to content

Conversation

@constantinius
Copy link
Contributor

…INTEGRATION_DEACTIVATES` to prohibit double span creation
@constantinius constantinius requested a review from a team as a code owner December 3, 2025 17:11
@linear
Copy link

linear bot commented Dec 3, 2025

@constantinius constantinius requested a review from a team December 3, 2025 17:11
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.20%. Comparing base (9a1b1aa) to head (5178a11).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5196      +/-   ##
==========================================
+ Coverage   82.94%   84.20%   +1.25%     
==========================================
  Files         181      181              
  Lines       18441    18441              
  Branches     3283     3283              
==========================================
+ Hits        15296    15528     +232     
+ Misses       2130     1899     -231     
+ Partials     1015     1014       -1     
Files with missing lines Coverage Δ
sentry_sdk/integrations/__init__.py 86.95% <ø> (-1.09%) ⬇️

... and 12 files with indirect coverage changes

LangchainIntegration,
OpenAIAgentsIntegration,
PydanticAIIntegration,
],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test doesn't verify OpenAI/Anthropic integrations are enabled

The test test_disabling_integrations_allows_openai_and_anthropic was expanded to disable OpenAIAgentsIntegration and PydanticAIIntegration in addition to LangchainIntegration, but the assertion still only verifies that LangchainIntegration not in integration_types. The test name implies it verifies that OpenAIIntegration and AnthropicIntegration are allowed to be enabled, but there's no assertion checking that they actually are in integration_types.

Fix in Cursor Fix in Web

@constantinius constantinius merged commit b61383b into master Dec 5, 2025
155 checks passed
@constantinius constantinius deleted the constantinius/fix/integrations/add-deactivates-for-openai-agents-and-pydantic-ai branch December 5, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants