-
Notifications
You must be signed in to change notification settings - Fork 569
fix(integrations): add values for pydantic-ai and openai-agents to _INTEGRATION_DEACTIVATES to prohibit double span creation
#5196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…INTEGRATION_DEACTIVATES` to prohibit double span creation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5196 +/- ##
==========================================
+ Coverage 82.94% 84.20% +1.25%
==========================================
Files 181 181
Lines 18441 18441
Branches 3283 3283
==========================================
+ Hits 15296 15528 +232
+ Misses 2130 1899 -231
+ Partials 1015 1014 -1
|
…ates-for-openai-agents-and-pydantic-ai
| LangchainIntegration, | ||
| OpenAIAgentsIntegration, | ||
| PydanticAIIntegration, | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Test doesn't verify OpenAI/Anthropic integrations are enabled
The test test_disabling_integrations_allows_openai_and_anthropic was expanded to disable OpenAIAgentsIntegration and PydanticAIIntegration in addition to LangchainIntegration, but the assertion still only verifies that LangchainIntegration not in integration_types. The test name implies it verifies that OpenAIIntegration and AnthropicIntegration are allowed to be enabled, but there's no assertion checking that they actually are in integration_types.
Issues
Contributes to: https://linear.app/getsentry/issue/TET-1511/openai-agents-double-span-reporting