Implement new Propagator.inject for OTLPIntegration #5221
+172
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
neel/otlp-outgoing-propagator
branch
2 times, most recently
from
ddec242 to
7f7d432
Compare
* bail out of `iter_trace_propagation_headers` if we have an
`external_propagation_context`
* handle outgoing headers as best as possible based on just the
available `SpanContext` from otel
* NOTE for baggage:
* is correctly passed through in the incoming case
* but for the head SDK, we cannot populate it in a persistent way
across the span tree (no transaction concept)
* so dynamic sampling with OTLP is out of scope right now
sl0thentr0py
force-pushed
the
neel/otlp-outgoing-propagator
branch
from
7f7d432 to
042f445
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| baggage = get_value(SENTRY_BAGGAGE_KEY, context) | ||
| if baggage is not None and isinstance(baggage, Baggage): | ||
| setter.set(carrier, BAGGAGE_HEADER_NAME, baggage.serialize()) |
There was a problem hiding this comment.
Bug: Empty baggage header may be set unexpectedly
The inject method sets the baggage header without checking if serialize() returns an empty string. When an incoming request has a sentry-trace header but no baggage header (or only third-party baggage items), the extract method creates an empty Baggage object that gets stored in context. On inject, baggage.serialize() returns "" for this empty baggage, resulting in an empty baggage header being set on outgoing requests. The parent class SentryPropagator avoids this by checking if baggage_data: before calling setter.set().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iter_trace_propagation_headersif we have anexternal_propagation_contextSpanContextfrom otelIssues