Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 11, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Breaking changes:

SubPRs:

💡 Motivation and Context

See #5273

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

Marking as Blocked while the Cocoa v9 is in Alpha

itaybre and others added 3 commits November 11, 2025 16:38
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

---------

Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

---------

Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>
Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

---------

Co-authored-by: Antonis Lilis <antonis.lilis@sentry.io>
Co-authored-by: Denis Andrasec <denrase@gmail.com>
Co-authored-by: Noah Martin <noahm444@gmail.com>
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 11, 2025
@antonis
Copy link
Contributor Author

antonis commented Nov 11, 2025

Adding the ready-to-merge label to trigger all tests but it's not really ready to merge 😅

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 425.27 ms 425.81 ms 0.54 ms
Size 43.94 MiB 48.90 MiB 4.96 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0b64753+dirty 358.55 ms 429.16 ms 70.61 ms
652f785+dirty 367.80 ms 390.71 ms 22.91 ms
3e0a5f9+dirty 379.92 ms 450.96 ms 71.04 ms
a02e30b+dirty 346.13 ms 381.76 ms 35.62 ms
e2fa43d+dirty 326.56 ms 372.88 ms 46.32 ms
a206511+dirty 331.54 ms 356.98 ms 25.44 ms
7480abe+dirty 363.80 ms 431.34 ms 67.54 ms
d916aa3+dirty 411.72 ms 451.76 ms 40.03 ms
534ba8c+dirty 472.35 ms 537.31 ms 64.96 ms
136effd+dirty 451.30 ms 450.87 ms -0.43 ms

App size

Revision Plain With Sentry Diff
0b64753+dirty 7.15 MiB 8.42 MiB 1.27 MiB
652f785+dirty 43.94 MiB 48.82 MiB 4.88 MiB
3e0a5f9+dirty 7.15 MiB 8.42 MiB 1.27 MiB
a02e30b+dirty 7.15 MiB 8.42 MiB 1.27 MiB
e2fa43d+dirty 7.15 MiB 8.42 MiB 1.27 MiB
a206511+dirty 43.94 MiB 48.90 MiB 4.96 MiB
7480abe+dirty 7.15 MiB 8.41 MiB 1.26 MiB
d916aa3+dirty 7.15 MiB 8.42 MiB 1.27 MiB
534ba8c+dirty 7.15 MiB 8.42 MiB 1.27 MiB
136effd+dirty 43.94 MiB 48.81 MiB 4.88 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
9aa9f9b+dirty 597.51 ms 634.22 ms 36.71 ms

App size

Revision Plain With Sentry Diff
9aa9f9b+dirty 43.94 MiB 48.90 MiB 4.96 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 426.45 ms 457.84 ms 31.39 ms
Size 43.75 MiB 48.07 MiB 4.32 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
652f785+dirty 401.02 ms 420.60 ms 19.58 ms
77061ed+dirty 369.55 ms 408.35 ms 38.80 ms
a206511+dirty 424.28 ms 474.82 ms 50.54 ms
b3b5b0d 399.82 ms 419.20 ms 19.38 ms
c4e097a 338.06 ms 439.36 ms 101.30 ms
136effd+dirty 398.57 ms 494.91 ms 96.34 ms
f17e051+dirty 396.23 ms 444.02 ms 47.79 ms
8490686+dirty 365.59 ms 400.24 ms 34.65 ms
a0b15d6 423.06 ms 437.77 ms 14.71 ms
bc9680d 375.15 ms 401.12 ms 25.97 ms

App size

Revision Plain With Sentry Diff
652f785+dirty 43.75 MiB 47.99 MiB 4.24 MiB
77061ed+dirty 17.75 MiB 19.68 MiB 1.94 MiB
a206511+dirty 43.75 MiB 48.07 MiB 4.32 MiB
b3b5b0d 17.75 MiB 19.68 MiB 1.94 MiB
c4e097a 17.75 MiB 19.68 MiB 1.94 MiB
136effd+dirty 43.75 MiB 47.99 MiB 4.23 MiB
f17e051+dirty 43.75 MiB 48.07 MiB 4.32 MiB
8490686+dirty 17.75 MiB 19.70 MiB 1.96 MiB
a0b15d6 17.75 MiB 20.15 MiB 2.41 MiB
bc9680d 17.75 MiB 20.15 MiB 2.41 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
9aa9f9b+dirty 464.02 ms 490.62 ms 26.60 ms

App size

Revision Plain With Sentry Diff
9aa9f9b+dirty 43.75 MiB 48.07 MiB 4.32 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1188.46 ms 1201.64 ms 13.18 ms
Size 3.41 MiB 4.74 MiB 1.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8490686+dirty 1227.32 ms 1240.82 ms 13.50 ms
c1573b3+dirty 1245.69 ms 1245.48 ms -0.21 ms
526494a+dirty 1220.96 ms 1221.57 ms 0.61 ms
161947d+dirty 1203.45 ms 1217.83 ms 14.38 ms
e76d0d3+dirty 1229.94 ms 1228.04 ms -1.90 ms
a2bb688+dirty 1244.82 ms 1238.60 ms -6.22 ms
fa7bb7e+dirty 1226.27 ms 1241.88 ms 15.61 ms
af9331b+dirty 1230.08 ms 1233.24 ms 3.16 ms
55b77fc+dirty 1213.08 ms 1218.19 ms 5.11 ms
8d20c8e+dirty 1223.60 ms 1223.87 ms 0.27 ms

App size

Revision Plain With Sentry Diff
8490686+dirty 3.19 MiB 4.56 MiB 1.38 MiB
c1573b3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
526494a+dirty 3.41 MiB 4.58 MiB 1.17 MiB
161947d+dirty 3.19 MiB 4.56 MiB 1.37 MiB
e76d0d3+dirty 3.19 MiB 4.57 MiB 1.38 MiB
a2bb688+dirty 3.19 MiB 4.56 MiB 1.37 MiB
fa7bb7e+dirty 3.19 MiB 4.58 MiB 1.39 MiB
af9331b+dirty 3.19 MiB 4.48 MiB 1.29 MiB
55b77fc+dirty 3.41 MiB 4.58 MiB 1.17 MiB
8d20c8e+dirty 3.41 MiB 4.57 MiB 1.16 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
9aa9f9b+dirty 1217.00 ms 1212.65 ms -4.35 ms

App size

Revision Plain With Sentry Diff
9aa9f9b+dirty 3.41 MiB 4.74 MiB 1.33 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1210.09 ms 1217.29 ms 7.20 ms
Size 3.41 MiB 4.74 MiB 1.33 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8490686+dirty 1227.84 ms 1228.91 ms 1.08 ms
c1573b3+dirty 1203.33 ms 1202.47 ms -0.86 ms
526494a+dirty 1210.20 ms 1203.13 ms -7.08 ms
161947d+dirty 1203.43 ms 1217.00 ms 13.57 ms
e76d0d3+dirty 1223.04 ms 1216.80 ms -6.24 ms
a2bb688+dirty 1223.53 ms 1232.90 ms 9.37 ms
fa7bb7e+dirty 1216.23 ms 1225.04 ms 8.81 ms
af9331b+dirty 1233.61 ms 1230.50 ms -3.11 ms
55b77fc+dirty 1223.71 ms 1224.12 ms 0.41 ms
8d20c8e+dirty 1216.62 ms 1220.31 ms 3.69 ms

App size

Revision Plain With Sentry Diff
8490686+dirty 2.63 MiB 4.00 MiB 1.36 MiB
c1573b3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
526494a+dirty 3.41 MiB 4.58 MiB 1.17 MiB
161947d+dirty 2.63 MiB 3.99 MiB 1.36 MiB
e76d0d3+dirty 2.63 MiB 4.00 MiB 1.37 MiB
a2bb688+dirty 2.63 MiB 3.99 MiB 1.36 MiB
fa7bb7e+dirty 2.63 MiB 4.01 MiB 1.38 MiB
af9331b+dirty 2.63 MiB 3.91 MiB 1.28 MiB
55b77fc+dirty 3.41 MiB 4.58 MiB 1.17 MiB
8d20c8e+dirty 3.41 MiB 4.57 MiB 1.16 MiB

Previous results on branch: cocoa-v9

Startup times

Revision Plain With Sentry Diff
9aa9f9b+dirty 1216.96 ms 1214.32 ms -2.64 ms

App size

Revision Plain With Sentry Diff
9aa9f9b+dirty 3.41 MiB 4.74 MiB 1.33 MiB

@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0-alpha.0 chore(deps): update Cocoa SDK to v9.0.0-alpha Nov 13, 2025
@antonis
Copy link
Contributor Author

antonis commented Nov 13, 2025

fix(podspec): Cocoa V9 allow any alpha version

Thank you @philipphofmann 🦸

antonis and others added 2 commits November 13, 2025 12:00
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

---------

Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>
Co-authored-by: Denis Andrasec <denrase@gmail.com>
Co-authored-by: Noah Martin <noahm444@gmail.com>
* fix: Fixes SentryScreenFrames use after being converted to Swift

* Fix build

* Use non-experimental enableLogs

* bump target

* remove enable tracing

* Update enableLogs tests

* chore: Fix RNSentry after SentryFramesTracker conversion to swift

* Run linter

* Remove unused debug image provider imports

* Remove imports

* chore: Remove deprecated user property

* chore: Remove use of deprecate integrations API (#5304)

* Remove use of integrations in tests

* chore: Remove use of deprecated prop (#5322)

* ref: Move options to wrapper

* chore(sample): Bump MacOS sample to macos 12.0 wich is the minimum for v9

* chore(e2e): Cocoa-v9: Bump E2E to iOS 15.0

* Bump to 15.1 due to RN 0.81.0 requirements

---------

Co-authored-by: Itay Brenner <itay.brenner@sentry.io>
Co-authored-by: Itay Brenner <itaybrenner@hotmail.com>
Co-authored-by: Denis Andrasec <denrase@gmail.com>
Co-authored-by: Noah Martin <noahm444@gmail.com>
@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Nov 13, 2025
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Nov 13, 2025
@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0-rc chore(deps): update Cocoa SDK to v9.0.0 GA Dec 1, 2025
@lucas-zimerman
Copy link
Collaborator

V9 was released so I will unblock this issue

@antonis
Copy link
Contributor Author

antonis commented Dec 3, 2025

V9 was released so I will unblock this issue

Correct. I'll keep it in draft for now since we are not going to merge on the main branch but on v8.

I've also opened getsentry/sentry-cocoa#6942 that I hope is going to fix some of the issues

@antonis antonis changed the title chore(deps): update Cocoa SDK to v9.0.0 GA chore(deps): update Cocoa SDK to v9 Dec 11, 2025
@antonis antonis removed the ready-to-merge Triggers the full CI test suite label Dec 11, 2025
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Dec 11, 2025
@antonis
Copy link
Contributor Author

antonis commented Dec 11, 2025

The CI is 🟢 again with 9.1.0 and the current issues are solved. The sample app also behaved as expected in my manual tests 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants