Skip to content

Commit 2753412

Browse files
committed
add TODOs
1 parent 579bf2d commit 2753412

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

src/sentry/interfaces/stacktrace.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,9 @@ def get_context(lineno, context_line, pre_context=None, post_context=None):
9393

9494

9595
def is_newest_frame_first(event):
96+
# TODO: Investigate if we should keep this special-casing for python, since we don't special
97+
# case it anywhere else we check stacktrace order.
98+
# (See https://github.com/getsentry/sentry/pull/96719 for more context.)
9699
newest_first = event.platform not in ("python", None)
97100

98101
if env.request and env.request.user.is_authenticated:

src/sentry/users/api/serializers/user.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ def serialize(
203203
stacktrace_order = _SerializedStacktraceOrder(
204204
int(
205205
options.get("stacktrace_order", StacktraceOrder.DEFAULT)
206+
# TODO: This second `or` won't be necessary once we remove empty strings from the DB
206207
or StacktraceOrder.DEFAULT
207208
)
208209
)

0 commit comments

Comments
 (0)