feat(triage signals): Remove Scan Issues setting [feature flagged] #103205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ), | ||
| fields: [ | ||
| seerScannerAutomationField, | ||
| ...(isTriageSignalsFeatureOn ? [] : [seerScannerAutomationField]), |
Contributor
There was a problem hiding this comment.
Bug: Phantom Toggle Hides Automation Fields
When the triage-signals-v0 feature is enabled and seerScannerAutomation is false, the autofixAutomatingTuningField and automatedRunStoppingPointField will be hidden because their visible conditions check model?.getValue('seerScannerAutomation') === true. Removing the seerScannerAutomationField from the form doesn't change the underlying value, causing the dependent automation fields to remain hidden even though the toggle is no longer accessible to users.
Contributor
Author
There was a problem hiding this comment.
Yes that is true. It's an edge case we discussed on #proj-triage-signals and we are okay with it.
Contributor
|
i (🐒) do not know frontend. deferring to @roaga on this one |
roaga
approved these changes
Nov 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
…103205) ## PR Details + Removing the Scan issues setting for projects under the triage signals feature flag. + Post launch, new orgs will have it set to True since the default is True and existing orgs that explicitly set it to False will still have it as False + Implementation notion doc [link](https://www.notion.so/sentry/Triage-Signals-V0-Technical-Implementation-Details-2a18b10e4b5d8086a7ceddaf4194849a?source=copy_link#2a18b10e4b5d80869424fb52219c3ce9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details