chore(trace explorer): Use agentic search endpoint #105583
Merged
+143
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
+203
to
+210
| if (resultStart && resultEnd) { | ||
| // Strip 'Z' suffix to treat UTC dates as local time | ||
| const startLocal = resultStart.endsWith('Z') | ||
| ? resultStart.slice(0, -1) | ||
| : resultStart; | ||
| const endLocal = resultEnd.endsWith('Z') ? resultEnd.slice(0, -1) : resultEnd; | ||
| start = new Date(startLocal).toISOString(); | ||
| end = new Date(endLocal).toISOString(); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
nsdeschenes
reviewed
Jan 5, 2026
Contributor
nsdeschenes
left a comment
nsdeschenes
left a comment
There was a problem hiding this comment.
One small nit, and one thing that may be consolidated, rest is looking amazing!
🚀 🌔
Comment on lines
12
to
13
| const startLocal = start.endsWith('Z') ? start.slice(0, -1) : start; | ||
| const endLocal = end.endsWith('Z') ? end.slice(0, -1) : end; |
Contributor
There was a problem hiding this comment.
You may be able to "translate" this to local using moment, as we use the moment-timezone package 👀
Member
Author
There was a problem hiding this comment.
Sounds good, realizing ill have to do a few follow ups here as I need to make the Seer endpoint timezone aware. Right not it just assumes everything is UTC which is why I stripped the Z but that was a bandaid solution. Will update to moment then do a follow up after
Comment on lines
82
to
125
| function formatDateRangeForText(start: string, end: string): string { | ||
| // Treat UTC dates as local dates by removing the 'Z' suffix | ||
| const startLocal = start.endsWith('Z') ? start.slice(0, -1) : start; | ||
| const endLocal = end.endsWith('Z') ? end.slice(0, -1) : end; | ||
|
|
||
| const startDate = new Date(startLocal); | ||
| const endDate = new Date(endLocal); | ||
|
|
||
| // Check if times are at midnight (date-only range) | ||
| const startIsMidnight = | ||
| startDate.getHours() === 0 && | ||
| startDate.getMinutes() === 0 && | ||
| startDate.getSeconds() === 0; | ||
| const endIsMidnight = | ||
| endDate.getHours() === 0 && endDate.getMinutes() === 0 && endDate.getSeconds() === 0; | ||
| const endIsEndOfDay = | ||
| endDate.getHours() === 23 && | ||
| endDate.getMinutes() === 59 && | ||
| endDate.getSeconds() === 59; | ||
|
|
||
| const useDateOnly = startIsMidnight && (endIsMidnight || endIsEndOfDay); | ||
|
|
||
| const dateOptions: Intl.DateTimeFormatOptions = { | ||
| month: 'short', | ||
| day: 'numeric', | ||
| year: 'numeric', | ||
| }; | ||
|
|
||
| const dateTimeOptions: Intl.DateTimeFormatOptions = { | ||
| month: 'short', | ||
| day: 'numeric', | ||
| year: 'numeric', | ||
| hour: 'numeric', | ||
| minute: '2-digit', | ||
| }; | ||
|
|
||
| const formatOptions = useDateOnly ? dateOptions : dateTimeOptions; | ||
|
|
||
| const startFormatted = startDate.toLocaleString('en-US', formatOptions); | ||
| const endFormatted = endDate.toLocaleString('en-US', formatOptions); | ||
|
|
||
| return `${startFormatted} to ${endFormatted}`; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
This looks like the same function in askSeerCombobox/queryTokens.tsx, can they be consolidated into a single function here in utils, and imported into queryTokens?
nsdeschenes
approved these changes
Jan 5, 2026
cathteng
pushed a commit
that referenced
this pull request
Jan 5, 2026
- Use agentic search endpoint for translation for internal use instead of the one shot workflow - Update to support start/end - Don't show time if beginning to end of day <img width="2483" height="709" alt="Screenshot 2026-01-02 at 12 52 02 PM" src="https://github.com/user-attachments/assets/413c6e0f-9149-4f00-94eb-965cef38e554" /> <img width="1892" height="577" alt="Screenshot 2026-01-02 at 12 52 06 PM" src="https://github.com/user-attachments/assets/ec6408d2-68dc-45d0-b710-7b4b97071eb9" /> <img width="1848" height="531" alt="Screenshot 2026-01-02 at 12 52 13 PM" src="https://github.com/user-attachments/assets/6413fec0-8c3d-412d-b9ee-fbbe5471547f" /> <img width="1746" height="256" alt="Screenshot 2026-01-02 at 12 52 39 PM" src="https://github.com/user-attachments/assets/e4c6e080-52c0-4997-936f-49e2162d4adf" /> <img width="1251" height="547" alt="Screenshot 2026-01-02 at 12 52 45 PM" src="https://github.com/user-attachments/assets/d75c2945-48a2-477f-82ee-fc0040981890" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.