fix(code-review): Unify metrics for easier dashboarding #105587
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Member
Author
|
@sentry review |
suejung-sentry
force-pushed
the
sshin/metrics
branch
2 times, most recently
from
dfb8c72 to
9cc57f6
Compare
github-actions
bot
added
the
Scope: Frontend
suejung-sentry
force-pushed
the
sshin/metrics
branch
2 times, most recently
from
b1213ec to
e95ed4c
Compare
suejung-sentry
removed
the
Scope: Frontend
suejung-sentry
force-pushed
the
sshin/metrics
branch
from
e95ed4c to
7b6327e
Compare
suejung-sentry
force-pushed
the
sshin/metrics
branch
from
7b6327e to
e1bc52e
Compare
suejung-sentry
force-pushed
the
sshin/metrics
branch
from
e1bc52e to
ccc2c57
Compare
suejung-sentry
force-pushed
the
sshin/metrics
branch
from
ccc2c57 to
0c72107
Compare
suejung-sentry
force-pushed
the
sshin/metrics
branch
from
0c72107 to
6ec1946
Compare
suejung-sentry
commented
Jan 3, 2026
| ERROR = "seer.code_review.error" | ||
|
|
||
|
|
||
| SUCCESS_STATUS = "success" |
Member
Author
There was a problem hiding this comment.
This seemed to be an unused variable
suejung-sentry
commented
Jan 3, 2026
| MISSING_ORGANIZATION = "github.webhook.check_run.missing-organization" | ||
| MISSING_ACTION = "github.webhook.check_run.missing-action" | ||
| INVALID_PAYLOAD = "github.webhook.check_run.invalid-payload" | ||
| INVALID_EXTERNAL_ID = "github.webhook.check_run.invalid-external-id" |
Member
Author
There was a problem hiding this comment.
These 2 under "Log" seemed to be unused
suejung-sentry
commented
Jan 3, 2026
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class ErrorStatus(enum.StrEnum): |
Member
Author
There was a problem hiding this comment.
These were moved over the metrics.py file
suejung-sentry
commented
Jan 3, 2026
|
|
||
|
|
||
| class Metrics(enum.StrEnum): | ||
| ERROR = "seer.code_review.error" |
Member
Author
There was a problem hiding this comment.
This was moved to metrics.py file
suejung-sentry
commented
Jan 3, 2026
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class ErrorStatus(enum.StrEnum): |
Member
Author
There was a problem hiding this comment.
Moved to metrics.py
suejung-sentry
commented
Jan 3, 2026
| NOT_REVIEW_COMMAND = "github.webhook.issue_comment.not-review-command" | ||
|
|
||
|
|
||
| class Metrics(enum.StrEnum): |
Member
Author
There was a problem hiding this comment.
Reworked into metrics.py
suejung-sentry
force-pushed
the
sshin/metrics
branch
from
6ec1946 to
73d7389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Draft dashboard planning here - https://www.notion.so/sentry/Code-Review-Observability-2dc8b10e4b5d80ef87e6c8a28cd820a7?source=copy_link#2dd8b10e4b5d80d0bf96eb576cf708dc
Closes CW-105