Modified Scraps Graphics Token Values #105598
Closed
+20
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| const graphics = { | ||
| ...tokens.graphics, | ||
| muted: tokens.graphics.neutral.moderate, | ||
| // Apply compatability Proxy to deprecated tokens |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ...tokens.graphics, | ||
| muted: tokens.graphics.neutral.moderate, | ||
| // Apply compatability Proxy to deprecated tokens | ||
| muted: createBackwardsCompatibleToken(tokens.graphics.neutral), |
Contributor
There was a problem hiding this comment.
Graphics muted token now returns wrong color value
The change from tokens.graphics.neutral.moderate to createBackwardsCompatibleToken(tokens.graphics.neutral) alters the legacy behavior of graphics.muted. Previously, when used as a string, it returned the moderate color. Now the proxy returns vibrant when coerced to string (per createBackwardsCompatibleToken implementation). The deprecation comment also states graphics.muted should map to graphics.neutral.moderate, not vibrant. This will cause existing usages of graphics.muted to render a different color.
TkDodo
approved these changes
Jan 2, 2026
Member
|
Closing in favor of #105641 |
natemoo-re
added a commit
that referenced
this pull request
Jan 5, 2026
Replaces #105598. Updates all variants of the `tokens.graphics` and `tokens.border.muted`. See the breadcrumb text and icons examples below. | Before | After | |--------|--------| | <img width="1280" alt="tokens-light-old" src="https://github.com/user-attachments/assets/1cb4b024-5991-4f8e-90a5-407ee59756ff" /> | <img width="1280" alt="tokens-light-new" src="https://github.com/user-attachments/assets/6a3ca496-e121-4da3-9e93-8c76f7e13a16" /> | | <img width="1280" alt="tokens-dark-old-1" src="https://github.com/user-attachments/assets/a8a679f1-cef7-4103-bb04-220bee0e5da2" /> | <img width="1280" alt="tokens-dark-new" src="https://github.com/user-attachments/assets/f7e9289f-0c4d-47f5-bdf2-a2431fa05297" />
cathteng
pushed a commit
that referenced
this pull request
Jan 5, 2026
Replaces #105598. Updates all variants of the `tokens.graphics` and `tokens.border.muted`. See the breadcrumb text and icons examples below. | Before | After | |--------|--------| | <img width="1280" alt="tokens-light-old" src="https://github.com/user-attachments/assets/1cb4b024-5991-4f8e-90a5-407ee59756ff" /> | <img width="1280" alt="tokens-light-new" src="https://github.com/user-attachments/assets/6a3ca496-e121-4da3-9e93-8c76f7e13a16" /> | | <img width="1280" alt="tokens-dark-old-1" src="https://github.com/user-attachments/assets/a8a679f1-cef7-4103-bb04-220bee0e5da2" /> | <img width="1280" alt="tokens-dark-new" src="https://github.com/user-attachments/assets/f7e9289f-0c4d-47f5-bdf2-a2431fa05297" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vibrantgraphics groupcontentto includecreateBackwardsComaptibleTokenformutedScreenshots
Before Light
Before Dark
After Light
After Dark