fix(auth-v2): CSRF redirect logic #96455
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| @@ -137,7 +137,7 @@ <h2>{% trans "CSRF Validation Failed" %}</h2> | |||
| localStorage.setItem('lastCsrfError', new Date().toISOString()); | |||
|
|
|||
| button.disabled = true; | |||
| status.textContent = '{% trans "Automatically rotating tokens..." %}'; | |||
| status.textContent = 'Automatically rotating tokens...'; | |||
There was a problem hiding this comment.
Bug: Token Rotation Message and I18n Issues
This commit introduces two bugs:
- The "Token rotated! Refreshing the page in 1 sec..." message is misleading, as the page now redirects to
/auth/login/instead of refreshing the current page. - Internationalization support was removed from several user-facing JavaScript strings by replacing Django translation tags (
{% trans %}) with hardcoded English text. This breaks multi-language support for messages such as "Rotating...", "Token rotated! Refreshing the page in 1 sec...", "Failed to rotate token.", "Rotate CSRF Token", and "Automatically rotating tokens...", causing them to always display in English and creating inconsistent internationalization with the rest of the template.
cathteng
approved these changes
Jul 25, 2025
|
Maybe if we're already on the CSRF url you redirect to login |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.