Skip to content

fix(tasks) Provide custom sampling context for taskworker #96463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025

Conversation

markstory
Copy link
Member

When reading through our SDK configuration code, I noticed that we had implemented custom sampling rates for tasks. This change should make the same sampling rates apply to taskworker tasks.

When reading through our SDK configuration code, I noticed that we had
implemented custom sampling rates for tasks. This change should make the
same sampling rates apply to taskworker tasks.
@markstory markstory requested review from a team as code owners July 25, 2025 18:51
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 25, 2025
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/utils/sdk.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #96463   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files       10642    10643    +1     
  Lines      614424   614435   +11     
  Branches    24127    24127           
=======================================
+ Hits       515087   515097   +10     
- Misses      98956    98957    +1     
  Partials      381      381           

@markstory markstory requested a review from a team July 30, 2025 18:44
@markstory markstory merged commit ec1ea6b into master Jul 30, 2025
66 checks passed
@markstory markstory deleted the feat-taskworker-sampler branch July 30, 2025 19:37
andrewshie-sentry pushed a commit that referenced this pull request Aug 4, 2025
When reading through our SDK configuration code, I noticed that we had
implemented custom sampling rates for tasks. This change should make the
same sampling rates apply to taskworker tasks.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants