Skip to content

fix(replays): Improve event parser to extract correct fields and handle known bad fields gracefully #96467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 28, 2025
Merged

fix(replays): Improve event parser to extract correct fields and handle known bad fields gracefully #96467

merged 5 commits into from
Jul 28, 2025

Conversation

cmanallen
Copy link
Member

No description provided.

@cmanallen cmanallen requested a review from a team as a code owner July 25, 2025 19:19
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 25, 2025
cursor[bot]
cursor bot reviewed Jul 25, 2025
View reviewed changes
aliu39
aliu39 approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was description/url removed from nav events?

@cmanallen
Copy link
Member Author

@aliu39 Because it doesn't exist.

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.15686% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/replays/lib/summarize.py 0.00% 2 Missing ⚠️
src/sentry/replays/usecases/ingest/event_parser.py 91.66% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #96467       +/-   ##
===========================================
+ Coverage   37.97%   87.73%   +49.76%     
===========================================
  Files       10011    10652      +641     
  Lines      561646   614663    +53017     
  Branches    24155    24155               
===========================================
+ Hits       213292   539305   +326013     
+ Misses     348065    75069   -272996     
  Partials      289      289

@cmanallen cmanallen merged commit 91bdd10 into master Jul 28, 2025
65 checks passed
@cmanallen cmanallen deleted the cmanallen/replays-event-parser-improvements branch July 28, 2025 13:07
andrewshie-sentry pushed a commit that referenced this pull request Aug 4, 2025
@cmanallen @andrewshie-sentry
fix(replays): Improve event parser to extract correct fields and hand…
c0fb8c0 
…le known bad fields gracefully (#96467)
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@aliu39 aliu39 aliu39 approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmanallen @aliu39