Skip to content

ref(replays): Add metrics for replay-event presence tracking #96473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

ref(replays): Add metrics for replay-event presence tracking #96473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14cc462
Add metrics for replay-event presence tracking
cmanallen Jul 25, 2025
195df87
Fix import
cmanallen Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/sentry/replays/consumers/recording.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
process_recording_event,
track_recording_metadata,
)
from sentry.utils import json
from sentry.utils import json, metrics

RECORDINGS_CODEC: Codec[ReplayRecording] = get_topic_codec(Topic.INGEST_REPLAYS_RECORDINGS)

Expand Down Expand Up @@ -108,6 +108,9 @@ def parse_recording_event(message: bytes) -> Event:
if replay_event_json:
replay_event = json.loads(cast(bytes, replay_event_json))
else:
# Check if any events are not present in the pipeline. We need
# to know because we want to write to Snuba from here soon.
metrics.incr("sentry.replays.consumer.recording.missing-replay-event")
replay_event = None

replay_video_raw = recording.get("replay_video")
Expand Down
Loading