feat(aci): Add edit detector page for error type #96482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
force-pushed
the
malwilley/feat/aci-edit-detector-error
branch
from
fa50eb7 to
bf10c4f
Compare
github-actions
bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| </Section> | ||
| </Container> | ||
| <AutomateSection /> | ||
| </FormStack> |
There was a problem hiding this comment.
Bug: Duplicate and Misleading Section Titles
The ErrorDetectorForm component in static/app/views/detectors/components/forms/error/index.tsx contains two sections both titled "Prioritize". The second section (around line 79), which describes "Auto Resolve Settings", is mislabeled. Its title should be "Resolve" to accurately reflect its content and avoid UI confusion.
Locations (2)
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
malwilley
changed the title
malwilley
force-pushed
the
malwilley/feat/aci-edit-detector-error
branch
from
bf10c4f to
817496d
Compare
malwilley
force-pushed
the
malwilley/feat/aci-edit-detector-error
branch
from
817496d to
0c17ce7
Compare
malwilley
removed
the
Scope: Backend
scttcper
approved these changes
Jul 25, 2025
…edit-detector-error
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving connected automations doesn't work with the API yet (the validator doesn't like the lack of condition groups), but I wrote a test for it.