chore(aci milestone 3): subscription processor memory + execution time metrics #96713
+204
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
kcons
reviewed
Jul 29, 2025
|
|
||
| if aggregation_value is not None: | ||
| with ( | ||
| metrics.timer( |
There was a problem hiding this comment.
haven't checked, but might be simpler (at least in diff) to move the body of this to a function we call. not sure how many vars we'd need to pass around, but something to consider.
kcons
approved these changes
Jul 29, 2025
| ), | ||
| track_memory_usage( | ||
| "incidents.alert_rules.process_update_memory", | ||
| tags={"dual_processing": has_metric_alert_processing}, |
There was a problem hiding this comment.
if there'll be other modes here, might want to make this an arbitrary string so history is relevant. Otherwise, this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track execution time + memory usage for dual processing vs not dual processing. Diff is large because of indentation.