feat(aci): set up monitor Disable action #96716
Open
+186
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ameliahsu
force-pushed
the
mia/aci/disable-monitors
branch
from
c5c6e75 to
764b583
Compare
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
malwilley
reviewed
Jul 30, 2025
static/app/views/detectors/components/details/common/actions.tsx
Outdated
Show resolved
Hide resolved
| return ( | ||
| <Button size="sm" onClick={() => {}}> | ||
| {detector.disabled ? t('Enable') : t('Disable')} | ||
| <Button size="sm" onClick={toggleDisabled} busy={isUpdating}> |
There was a problem hiding this comment.
I think you still need to set disabled={isUpdating} so that the user can't click it twice, I'm not sure if busy does that for you
There was a problem hiding this comment.
this is handled by busy!
sentry/static/app/components/core/button/useButtonFunctionality.tsx
Lines 27 to 33 in 412d1c0
| export function DeleteDetectorAction({detector}: {detector: Detector}) { | ||
| const organization = useOrganization(); | ||
| const navigate = useNavigate(); | ||
| const {mutate: deleteDetector, isPending: isDeleting} = useDeleteDetectorMutation(); |
There was a problem hiding this comment.
If you use mutateAsync instead for the onConfirm, the modal will stay open until the request finishes which is slightly better UX
There was a problem hiding this comment.
shoot i forgot this again 🤦🏼
ameliahsu
force-pushed
the
mia/aci/disable-monitors
branch
from
3123ad2 to
ca7d19c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connected Disable button to detector PUT endpoint
since we already have individual components for each action button now (file here), i figured we could take out the
EditDetectorActionscomponent and place the buttons intoEditDetectorLayoutdirectly