ggml-cpu : deduplicate scalar implementations #14897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
slaren
reviewed
Jul 27, 2025
ggerganov
approved these changes
Jul 28, 2025
slaren
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant scalar fallback implementations from architecture-specific code that were added in a previous refactor, replacing them with calls to generic implementations. The cleanup eliminates duplicated scalar computation code across different CPU architectures while maintaining the same functionality through centralized generic fallback functions.
Key changes:
- Replaced architecture-specific scalar implementations with calls to generic functions
- Added UNUSED macros to silence compiler warnings for variables no longer used in fallback paths
- Maintained existing optimized vectorized code paths while cleaning up fallback implementations
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ggml/src/ggml-cpu/arch/x86/repack.cpp | Replaced scalar implementations with generic function calls for quantization and matrix operations |
| ggml/src/ggml-cpu/arch/x86/quants.c | Removed duplicated scalar fallback code for vector dot product operations |
| ggml/src/ggml-cpu/arch/wasm/quants.c | Cleaned up scalar implementations in WebAssembly-specific code |
| ggml/src/ggml-cpu/arch/s390/quants.c | Removed redundant scalar fallbacks in s390 architecture code |
| ggml/src/ggml-cpu/arch/riscv/repack.cpp | Simplified RISC-V repack operations by using generic implementations |
| ggml/src/ggml-cpu/arch/riscv/quants.c | Restructured conditional compilation and removed scalar duplications |
| ggml/src/ggml-cpu/arch/powerpc/quants.c | Eliminated redundant scalar code in PowerPC architecture implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up redundant fallback implementations in each architecture, which were introduced in the previous refactor PR #13892.