-
Notifications
You must be signed in to change notification settings - Fork 13.7k
server: split HTTP into its own interface #17216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0594df9 to
45b2fe1
Compare
|
No rush for reviewing this, would appreciate if you can do some testings on your side @ggerganov In the next PR, I'll try to break the
While working on this, I'm also thinking about maybe re-using server code in |
Fix #16488
How it works:
sequenceDiagram participant User participant server_http_context participant server_http_res User->>server_http_context: request server_http_context->>server_http_req: create request server_http_req->>handler: handler->>server_http_res: create response loop for each result server_http_res->>server_http_context: response chunk server_http_context->>User: response chunk server_http_context->>server_http_res: next() end server_http_res->>server_http_context: terminate server_http_context->>User: close connectionserver_res_generator, which is a derived class fromserver_http_resserver_res_generatorindicates one of 2 modes: stream or non-streamserver_res_generator::next()until it returnsfalse. Each time we callnext(), we get a new chunk of dataTODO:
server_routeslevelTesting:
tests.sh