Skip to content

Conversation

@angt
Copy link
Collaborator

@angt angt commented Nov 13, 2025

No description provided.

@angt angt requested a review from CISC as a code owner November 13, 2025 11:53
@ngxson
Copy link
Collaborator

ngxson commented Nov 13, 2025

I think we should have CI dedicated to testing openssl instead of completely replace it.

The CI is suppose to validate the build with default config that will be pushed to end-user. If we aim to make openssl as default, we should change its default value in cmakelists instead.

@angt
Copy link
Collaborator Author

angt commented Nov 13, 2025

The idea is to remove completely the use of libcurl and all the code related.
I'm waiting the boringssl PR to replace it everywhere :)

@ngxson
Copy link
Collaborator

ngxson commented Nov 13, 2025

The idea is to remove completely the use of libcurl and all the code related.

In this case, it makes more sense to the default value in cmakelists; probably also put up a deprecation warning when LLAMA_CURL is enabled

@angt
Copy link
Collaborator Author

angt commented Nov 13, 2025

The plan is to replace the current libcurl build with OpenSSL and BoringSSL (not only OpenSSL) first in the CI, then in all releases. If successful, I will deprecate the code by adding a warning message during the build process. And then changing the default.

I wouldn’t enable OpenSSL by default as a first step; this is guaranteed to make a lot of useless frictions.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Nov 13, 2025
Signed-off-by: Adrien Gallouët <angt@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants