Skip to content

remove match amount min check #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove match amount min check #3825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/common/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ export const fetchPassport = (
communityId: string,
apiKey: string
): Promise<Response> => {
console.log("fetchPassport: hammer time", {
address,
});
const url = `${process.env.REACT_APP_PASSPORT_API_ENDPOINT}/v2/stamps/${communityId}/score/${address}`;
return fetch(url, {
method: "GET",
Expand Down
12 changes: 3 additions & 9 deletions packages/round-manager/src/features/round/ViewRoundSettings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,14 +245,7 @@ export default function ViewRoundSettings(props: {
),
}),
quadraticFundingConfig: yup.object({
matchingFundsAvailable: yup
.number()
.typeError("Invalid value.")
.min(
round?.roundMetadata?.quadraticFundingConfig
?.matchingFundsAvailable ?? 0,
`Must be greater than previous value of ${round?.roundMetadata?.quadraticFundingConfig?.matchingFundsAvailable}.`
),
matchingFundsAvailable: yup.number().typeError("Invalid value."),
matchingCapAmount: yup.number().when("matchingCap", {
is: (val: string) => val === "yes",
then: yup
Expand Down Expand Up @@ -2087,7 +2080,8 @@ function Funding(props: {
?.matchingCap !== true
}
checked={
!props.editedRound?.roundMetadata?.quadraticFundingConfig?.matchingCap
!props.editedRound?.roundMetadata?.quadraticFundingConfig
?.matchingCap
}
onChange={(e) => {
props.resetField(
Expand Down