Skip to content

Conversation

@Fredi-raspall
Copy link
Contributor

@Fredi-raspall Fredi-raspall commented Dec 17, 2025

@Fredi-raspall Fredi-raspall requested a review from a team as a code owner December 17, 2025 15:18
@Fredi-raspall Fredi-raspall requested review from qmonnet and removed request for a team December 17, 2025 15:18
@Fredi-raspall Fredi-raspall changed the base branch from main to pr/fredi/multigw_failover December 17, 2025 15:18
@Fredi-raspall Fredi-raspall added ci:-upgrade Disable VLAB upgrade tests ci:-vlab Disable VLAB tests labels Dec 17, 2025
@mvachhar mvachhar added the dont-merge Do not merge this Pull Request label Dec 17, 2025
@mvachhar
Copy link
Contributor

I merged the gateway-proto repository, so please cut a new release there. I believe just adding a tag to that repo will automatically create the new release. Then this PR can be updated with the new tag and merge. Please confirm that this procedure is correct with @Frostman as I cannot recall if that is sufficient.

@Fredi-raspall
Copy link
Contributor Author

I merged the gateway-proto repository, so please cut a new release there. I believe just adding a tag to that repo will automatically create the new release. Then this PR can be updated with the new tag and merge. Please confirm that this procedure is correct with @Frostman as I cannot recall if that is sufficient.

I do not remember either.

@mvachhar mvachhar removed the dont-merge Do not merge this Pull Request label Dec 17, 2025
@mvachhar mvachhar self-requested a review December 17, 2025 21:15
@qmonnet qmonnet removed their request for review December 17, 2025 21:17
@Fredi-raspall Fredi-raspall force-pushed the pr/fredi/multigw_failover branch from 9983a75 to 7c94777 Compare December 18, 2025 09:07
@Fredi-raspall Fredi-raspall force-pushed the pr/fredi/multigw_failover branch from 7c94777 to bb0f4f7 Compare December 18, 2025 10:42
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Deprecating those fields requires a new version of gateway-proto.
Otherwise the fuzzing tests fail.

Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
@Fredi-raspall Fredi-raspall force-pushed the pr/fredi/multigw_failover branch from bb0f4f7 to c73daaa Compare December 18, 2025 13:35
@mvachhar mvachhar merged commit a281af7 into pr/fredi/multigw_failover Dec 18, 2025
22 checks passed
@mvachhar mvachhar deleted the pr/fredi/cleanup_model branch December 18, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:-upgrade Disable VLAB upgrade tests ci:-vlab Disable VLAB tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants