mgmt cleanup 1 add client #1156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fredi-raspall
force-pushed
the
pr/fredi/multigw_failover
branch
from
ca9283d to
230afbc
Compare
Fredi-raspall
force-pushed
the
pr/fredi/mgmt-cleanup-1-add-client
branch
3 times, most recently
from
5b63da7 to
385010c
Compare
Fredi-raspall
force-pushed
the
pr/fredi/multigw_failover
branch
from
9c6b110 to
38da8f8
Compare
Fredi-raspall
force-pushed
the
pr/fredi/mgmt-cleanup-1-add-client
branch
from
385010c to
d2d1d03
Compare
Fredi-raspall
force-pushed
the
pr/fredi/mgmt-cleanup-1-add-client
branch
2 times, most recently
from
1696c6e to
c490645
Compare
Fredi-raspall
force-pushed
the
pr/fredi/multigw_failover
branch
from
455d0f7 to
3ee0cb5
Compare
Fredi-raspall
force-pushed
the
pr/fredi/mgmt-cleanup-1-add-client
branch
from
c490645 to
d2d7f26
Compare
The ConfigClient is the entity used to interact with the config processor. This abstraction will allow us to simplify configuration entry points (grpc/k8s or any other), hiding the internals of the communication that are now unnecessarily exposed. This is the first commit in a series to simplify the mgmt crate. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Let gRPC server and k8s_client use the ConfigClient object (instead of a Sender<ConfigRequest>) to send requests and receive responses from the configuration processor. This simplifies the code and the required types to imnport. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Let the k8s_client own a ConfigClient so that it does not need to be propagated throughout. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Fredi-raspall
force-pushed
the
pr/fredi/mgmt-cleanup-1-add-client
branch
from
d2d7f26 to
3be1c37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.